Giter Site home page Giter Site logo

Comments (10)

dunglas avatar dunglas commented on May 29, 2024

Indeed it's a bug, we should do that!

from website.

lex111 avatar lex111 commented on May 29, 2024

You mind if I handle this two bugs, okay?

from website.

dunglas avatar dunglas commented on May 29, 2024

You're very welcome!

from website.

lex111 avatar lex111 commented on May 29, 2024

I suggest making the markup more semantic, like this:

<figure class="symfonycasts"><a href="#"><img src="#" alt="#"><figcaption>Optional caption</figcaption></a></figure>

It's good for you?

from website.

dunglas avatar dunglas commented on May 29, 2024

Yes it's even better!

from website.

lex111 avatar lex111 commented on May 29, 2024

Hmm, I just thought that we can simplify the insertion SC block a bit, I mean use something like shortcode.
For example, symfonycasts:alt="JWT screencast" link="https://symfonycasts.com/tracks/rest?cid=apip#api-platform" transforms to HTML!

<p class="symfonycasts"><a href="https://symfonycasts.com/tracks/rest?cid=apip#api-platform" class="symfonycasts"><img src="../distribution/images/symfonycasts-player.png" alt="JWT screencast"></a></span></p>

How does that sound?

from website.

dunglas avatar dunglas commented on May 29, 2024

Will it work when browsing the doc files directly in GitHub? Also, Everywhere else we have a caption at the bottom of the player.

from website.

lex111 avatar lex111 commented on May 29, 2024

Will it work when browsing the doc files directly in GitHub?

Um, nope, but is that really important? I mean, who reads the documentation on GitHub? I think you can give that up.

Also, Everywhere else we have a caption at the bottom of the player.

Of course, caption can be provided, this is a concept, I did not just specify it.

from website.

dunglas avatar dunglas commented on May 29, 2024

Many people read the docs directly from GH, or from their IDE. I think we should stick to standard markdown

from website.

lex111 avatar lex111 commented on May 29, 2024

Hmm, really a pity, all the more it is a valid inline code and by its contents you can understand what it represents. And we could significantly simplify the insertion of SC block, but for some reason we manually duplicate the code each time...

Nevertheless, it is strange that in reality many people read the docs on GH, it’s at least inconvenient, and it’s faster to open a website with documentation. So this is a moot point, as for me.

Well, those who look at the docs from their IDE are just the developers who do this only to edit the docs, especially considering the separate docs repository.

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.