Giter Site home page Giter Site logo

Comments (4)

mtrunkat avatar mtrunkat commented on May 10, 2024

There is a options.disableProxy parameter. We should either disable it by default or change integration with Apify Proxy.

from crawlee.

jancurn avatar jancurn commented on May 10, 2024

Apify.launchPuppeteer() should not require any proxy when running locally but probably should use it by default when running on Apify cloud, while enabling the user to disable it. The parameter options.disableProxy is not great, because it's not obvious it's Apify proxy - we should rename it to something like avoidApifyProxy.

from crawlee.

mtrunkat avatar mtrunkat commented on May 10, 2024

So what about to add options.useApifyProxy and by default to run without proxy? Thats expected behavior for SDK.

We need this configuration at multiple levels:
Apify.launchPuppeteer()
Apify.PuppeteerPool
Apify.PuppeteerCrawler

So maybe this could be a part of launchPuppeteer's options and we can add parameter opts.launchPuppeteerOptions of type Object to both Apify.PuppeteerPool and Apify.PuppeteerCrawler.

from crawlee.

jancurn avatar jancurn commented on May 10, 2024

Yeah, that sounds good! BTW this is related to TODOs in launchPuppeteerFunction - see https://github.com/apifytech/apify-js/blob/master/src/puppeteer_pool.js#L34 we should move all these options into this object.

from crawlee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.