Unhandled error event on incorrect client password

[apify]

Unhandled error event on incorrect client password

[atymic]

Tested on node 10 & 12, same issue.

[atymic]

I've managed a bit of a ghetto fix by adding an error handler on the socket before sending the 407 response.

socket.on('error', (error) => {
	console.log(error)
	socket.end();
	socket.destroy();
});

I added it just about this line:
https://github.com/apifytech/proxy-chain/blob/master/src/server.js#L408

It seems to work ok, but i'm not sure if there's a socket/memory leak in there.
Either way better to fix the actual issue.

[jancurn]

Many thanks for reporting this, we'll look into it.

[atymic]

Thanks!

Let me know if you need any more info :)

[Flowr-es]

I think this one is the same. If the upstreamProxy receives wrong credentials it fails with logs but no event for the implementor. Or is there anyway to handle this?

Logs:
ProxyServer[3128]: 29 | !!! Closed and removed from server
ProxyServer[3128]: 22 | Connected to upstream proxy
ProxyServer[3128]: 22 | RequestError: Invalid credentials provided for the upstream proxy., responding with custom status code 502 to client
ProxyServer[3128]: 22 | Source response finished, ending source socket
ProxyServer[3128]: 26 | Connected to upstream proxy
ProxyServer[3128]: 26 | RequestError: Invalid credentials provided for the upstream proxy., responding with custom status code 502 to client
ProxyServer[3128]: 26 | Source response finished, ending source socket
ProxyServer[3128]: 28 | Connected to upstream proxy
ProxyServer[3128]: 28 | RequestError: Invalid credentials provided for the upstream proxy., responding with custom status code 502 to client
ProxyServer[3128]: 28 | Source response finished, ending source socket
ProxyServer[3128]: 22 | Source socket finished
ProxyServer[3128]: 22 | Closing handler

[jancurn]

Sorry guys, we didn't manage to get to fixing this. PRs are more than welcome! This should be a simple fix, the unit test might be slightly more complicated but I'd say manageable.

[jancurn]

Another instance of unhandled errors observed in our production system - might be related.

Feb 04 00:38:08 ip-172-31-62-20 [email protected] Emitted 'error' event on Socket instance at:
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  errno: 'ECONNRESET',
  code: 'ECONNRESET',
  syscall: 'read'
}
Feb 04 00:38:08 ip-172-31-62-20 [email protected] [Error] Error: read ECONNRESET
    at TCP.onStreamRead (internal/stream_base_commons.js:201:27)
Feb 04 00:38:08 ip-172-31-62-20 [email protected] events.js:187
      throw er; // Unhandled 'error' event
      ^

[jancurn]

This bug should be fixed in the latest release 0.4.0, by e454b87