Mac Lion SFML 1.6 Crash

[apitrace]

Mac Lion SFML 1.6 Crash

[jrfonseca]

It looks like we're overflowing the stack on MacOSX due to all foo[PATH_MAX] arrays allocated out of the stack.

This should fix it:

diff --git a/common/os_posix.cpp b/common/os_posix.cpp
index 98a790b..15999a9 100644
--- a/common/os_posix.cpp
+++ b/common/os_posix.cpp
@@ -67,7 +67,7 @@ ReleaseMutex(void)
bool
GetProcessName(char *str, size_t size)
{
- char szProcessPath[PATH_MAX + 1];
+ static char szProcessPath[PATH_MAX + 1];
char *lpProcessName;

     // http://stackoverflow.com/questions/1023306/finding-current-executables-path-without-proc-self-exe
diff --git a/common/trace_local_writer.cpp b/common/trace_local_writer.cpp
index e560e49..299878a 100644
--- a/common/trace_local_writer.cpp
+++ b/common/trace_local_writer.cpp
@@ -77,7 +77,7 @@ LocalWriter::open(void) {
     static unsigned dwCounter = 0;

     const char *szExtension = "trace";
-    char szFileName[PATH_MAX];
+    static char szFileName[PATH_MAX];
     const char *lpFileName;

     lpFileName = getenv("TRACE_FILE");
@@ -85,8 +85,8 @@ LocalWriter::open(void) {
         strncpy(szFileName, lpFileName, PATH_MAX);
     }
     else {
-        char szProcessName[PATH_MAX];
-        char szCurrentDir[PATH_MAX];
+        static char szProcessName[PATH_MAX];
+        static char szCurrentDir[PATH_MAX];
         OS::GetProcessName(szProcessName, PATH_MAX);
         OS::GetCurrentDir(szCurrentDir, PATH_MAX);

[jrfonseca]

Formatting got broken. I'll try paste once again:

diff --git a/common/os_posix.cpp b/common/os_posix.cpp
index 98a790b..15999a9 100644
--- a/common/os_posix.cpp
+++ b/common/os_posix.cpp
@@ -67,7 +67,7 @@ ReleaseMutex(void)
 bool
 GetProcessName(char *str, size_t size)
 {
-    char szProcessPath[PATH_MAX + 1];
+    static char szProcessPath[PATH_MAX + 1];
     char *lpProcessName;

     // http://stackoverflow.com/questions/1023306/finding-current-executables-path-without-proc-self-exe
diff --git a/common/trace_local_writer.cpp b/common/trace_local_writer.cpp
index e560e49..299878a 100644
--- a/common/trace_local_writer.cpp
+++ b/common/trace_local_writer.cpp
@@ -77,7 +77,7 @@ LocalWriter::open(void) {
     static unsigned dwCounter = 0;

     const char *szExtension = "trace";
-    char szFileName[PATH_MAX];
+    static char szFileName[PATH_MAX];
     const char *lpFileName;

     lpFileName = getenv("TRACE_FILE");
@@ -85,8 +85,8 @@ LocalWriter::open(void) {
         strncpy(szFileName, lpFileName, PATH_MAX);
     }
     else {
-        char szProcessName[PATH_MAX];
-        char szCurrentDir[PATH_MAX];
+        static char szProcessName[PATH_MAX];
+        static char szCurrentDir[PATH_MAX];
         OS::GetProcessName(szProcessName, PATH_MAX);
         OS::GetCurrentDir(szCurrentDir, PATH_MAX);

I won't commit this immediately because static arrays are a bit unclean (subject to race conditions), but I don't want to use malloc here neither... I'll just have to think a bit more about this.

[jrfonseca]

This should be now fixed with commit 0a41c9b