Giter Site home page Giter Site logo

Comments (4)

apocas avatar apocas commented on May 20, 2024 2

Dockerode's run was made basically as an entry point to dockerode, for more complex use case you really should implement your own. (create->attach->start->wait)

But since I seeing a lot of interest on this, probably the best course of action is to accept an optional options object and merge it with the internal optsc.

Ex:
Docker.prototype.run = function(image, cmd, streamo, [options], callback)
Merging options with optsc, giving preference to options.
Don't want this to be a breaking change, so options and callback type should be validated.

If you are not up to do a PR, I can implement this later today/tomorrow :)

from dockerode.

apocas avatar apocas commented on May 20, 2024

In master now. b5758de

Yet to be published.

from dockerode.

dweinstein avatar dweinstein commented on May 20, 2024

👍

from dockerode.

apocas avatar apocas commented on May 20, 2024

Published v1.2.10

from dockerode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.