Undocumented breaking change: container.logs now produces a string

[nwalters512]

Undocumented breaking change: container.logs now produces a string

[apocas]

Fixed.

[nwalters512]

Further investigation reveals that this is likely an issue with docker-modem, as installing an old version of that package (v3) on the latest master of dockerode results in the above test passing.

[nwalters512]

AFAICT, this was changed in this commit: apocas/docker-modem@8b415dd

It looks like this commit tried to revert that, but it is incorrectly using || result instead of || buffer: apocas/docker-modem@8e05417

@apocas I'd be happy to open a PR fixing this if you can confirm that the above revert was done incorrectly and it should actually return the buffer directly.

[apocas]

Hi,

So this was one part of the mess that got us in a major bump.
It was introduced in docker-modem from a PR that I accepted, I miss judged the consequences of that PR (converting it to stream).

Yes we should revert this, buffer is the proper type.

Best regards,

[nwalters512]

Thanks for confirming, I'll open a PR shortly!

[nwalters512]

apocas/docker-modem#161

[gallynero]

Is || buffer or || stream.Readable.from(buffer)?

[apocas]

buffer like it was before all this mess, going to publish docker-modem today
This method isn't "isstream".