Giter Site home page Giter Site logo

Comments (7)

martijnwalraven avatar martijnwalraven commented on July 23, 2024 3

Ah, that should be pretty easy to fix actually! Swift allows you to escape identifiers by using backticks. So in this case, you'd want the output to be:

/// The privacy modes for an album.
public enum AlbumPrivacies: String {
  case `public` = "PUBLIC" /// Public albums can be joined and viewed by anyone.
  case `private` = "PRIVATE" /// Private albums can be joined and viewed only with an invitation.
}

Unfortunately, it seems apollographql/apollo-tooling#33 doesn't take enum cases into account. But that should be a single line fix because the escapeIdentifierIfNeeded function has already been written.

from apollo-ios.

MrAlek avatar MrAlek commented on July 23, 2024

There's a closed issue on this here: apollographql/apollo-tooling#33

Edit: Seems to work for property names but maybe was missed for enum cases

from apollo-ios.

attheodo avatar attheodo commented on July 23, 2024

@MrAlek I guess it's missed. I am on apollo-codegen 0.10.4 and doesn't seem to work.

from apollo-ios.

attheodo avatar attheodo commented on July 23, 2024

@martijnwalraven any estimates on when the fix could make it to apollo-codegen ?

from apollo-ios.

martijnwalraven avatar martijnwalraven commented on July 23, 2024

@attheodo: Working on it right now, give me 15 min :)

from apollo-ios.

attheodo avatar attheodo commented on July 23, 2024

@martijnwalraven you Sir are awesome! Thanks!

from apollo-ios.

martijnwalraven avatar martijnwalraven commented on July 23, 2024

@attheodo: Should be fixed in apollo-codegen 0.10.6.

from apollo-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.