Comments (4)
Hello 👋
There is an explicit error when we use @key on an interface, but the spec is not v2.3+. Do you think you might be worth covering that as well? Here is the error I'm mentioning. Currently, we can use @key on interfaces, even on specs lower than v2.3.
While the @key
definition specified both OBJECT | INTERFACE
as valid locations, it never actually worked. I believe composition would just ignore (or drop?) whatever was on the interface. Since it was ignored, implementing types could define completely different @key
s or omit them altogether.
Therefore I think having an explicit error when using old fed versions makes more sense - i.e. otherwise end users might think that this feature works whereas it never did -> it is a user error. If this behavior is problematic we can probably change it to a warning message.
from federation-jvm.
Hello 👋
Just released 2.3.0-alpha.0.
Will release final v2.3.0
once the Federation Spec goes GA.
from federation-jvm.
Thanks for the quick response @dariuszkuc 🙌🏻
This alpha version will help test the v2.3
spec, so thanks a lot for the release.
Before you release the final version of the v2.3.0
spec support, I would love to address some cases introduced by the new spec around the @interfaceObject
directive/functionality. I already started working on a PR to addressing those, but will make sure to describe those here first and get some feedback before going any forward. Let me get back these days with some detailed cases we might need to cover in the final version.
from federation-jvm.
Hi @dariuszkuc
I just noticed that you extended the functionality here. I think that pretty much covers everything I had in mind, except one validation that was implemented in the federation package for the v2.3
spec.
There is an explicit error when we use @key
on an interface, but the spec is not v2.3+
. Do you think you might be worth covering that as well? Here is the error I'm mentioning. Currently, we can use @key
on interfaces, even on specs lower than v2.3
.
Thanks for the 2nd release 🙏🏻
from federation-jvm.
Related Issues (20)
- _service query should return non-nullable _Service type
- Composed directives must be consistently named across subgraph implementations and not use @federation__ prefix HOT 1
- Protobuf-java version is not correct in Maven Library for 2.X HOT 2
- Enable full CI/CD HOT 1
- Update Spring example to use the Apollo Router HOT 1
- Classpath issue on 2.1.0 HOT 2
- _entities error HOT 10
- @link appears to fail on "extend schema" HOT 4
- GraalVM Reachability Metadata for Apollo Federation JVM
- @inaccessible directives no longer returned in _service { sld } query, after release 0.7.0 HOT 5
- Feature Request: Support Error Masking Behavior
- 'link' directive definition is missing 'for' parameter HOT 2
- generateServiceSDL in ServiceSDLPrinter - invalid includeDirectives configfuration? HOT 1
- Action Required: Fix Renovate Configuration
- Federation 2.6 support HOT 1
- Importing and renaming @key directive HOT 1
- Federation scalars declared in the schema file don't get wired up by the transformer HOT 3
- N+1 problem with fetchEntities HOT 5
- Add configuration options to transformation of sdl or check for federation directives HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from federation-jvm.