Giter Site home page Giter Site logo

Comments (4)

dariuszkuc avatar dariuszkuc commented on June 11, 2024 1

Hello 👋

There is an explicit error when we use @key on an interface, but the spec is not v2.3+. Do you think you might be worth covering that as well? Here is the error I'm mentioning. Currently, we can use @key on interfaces, even on specs lower than v2.3.

While the @key definition specified both OBJECT | INTERFACE as valid locations, it never actually worked. I believe composition would just ignore (or drop?) whatever was on the interface. Since it was ignored, implementing types could define completely different @keys or omit them altogether.

Therefore I think having an explicit error when using old fed versions makes more sense - i.e. otherwise end users might think that this feature works whereas it never did -> it is a user error. If this behavior is problematic we can probably change it to a warning message.

from federation-jvm.

dariuszkuc avatar dariuszkuc commented on June 11, 2024

Hello 👋
Just released 2.3.0-alpha.0.

Will release final v2.3.0 once the Federation Spec goes GA.

from federation-jvm.

moonflare avatar moonflare commented on June 11, 2024

Thanks for the quick response @dariuszkuc 🙌🏻

This alpha version will help test the v2.3 spec, so thanks a lot for the release.

Before you release the final version of the v2.3.0 spec support, I would love to address some cases introduced by the new spec around the @interfaceObject directive/functionality. I already started working on a PR to addressing those, but will make sure to describe those here first and get some feedback before going any forward. Let me get back these days with some detailed cases we might need to cover in the final version.

from federation-jvm.

moonflare avatar moonflare commented on June 11, 2024

Hi @dariuszkuc
I just noticed that you extended the functionality here. I think that pretty much covers everything I had in mind, except one validation that was implemented in the federation package for the v2.3 spec.

There is an explicit error when we use @key on an interface, but the spec is not v2.3+. Do you think you might be worth covering that as well? Here is the error I'm mentioning. Currently, we can use @key on interfaces, even on specs lower than v2.3.

Thanks for the 2nd release 🙏🏻

from federation-jvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.