Introspection query doesn't return latest schema changes when query plan is being persisted on Redis

[nathanmarcos]

Introspection query doesn't return latest schema changes when query plan is being persisted on Redis

[nathanmarcos]

Hello @abernix, I tested it, and it works just fine. 🎉

Thanks @Geal for the quick fix. 🚀

[abernix]

This was released in https://github.com/apollographql/router/releases/tag/v1.45.1 via #5007. Note that we also brought in another (more critical) hashing fix to that release.

[Geal]

I think that is related to #4883
The query plan cache key uses a hash of the query that takes into account the relevant parts of the schema to avoid planning again queries that are not affected by a schema change, but I don't think it takes into account introspection queries.
We will soon separate introspection queries from the query planner cache so that will be solved definitely then, but in the meantime I think we should fix this quickly

The schema aware hash is in :

router/apollo-router/src/spec/query/change.rs

Lines 72 to 80 in a709cff

	pub(crate) fn hash_query(
	schema: &'a schema::Schema,
	executable: &'a executable::ExecutableDocument,
	operation_name: Option<&str>,
	) -> Result<Vec<u8>, BoxError> {
	let mut visitor = QueryHashVisitor::new(schema, executable);
	traverse::document(&mut visitor, executable, operation_name)?;
	Ok(visitor.finish())
	}

[abernix]

Thanks for opening this, @nathanmarcos. We're working on a 1.45.1 patch release with a couple things right now. In the meantime, are you in any position to be able to try the PR that is opened that purports to fix this (#5007)? (If you necessitate a Docker image or something, we could probably make that happen.)

[abernix]

Thanks for the validation, @nathanmarcos. Just to set expectations, it'll probably be a Friday release with that above patch and probably one other smaller fix.

[nathanmarcos]

No problem. That sounds good, thanks @abernix . 😉