Add standard attributes to all LOGS from request/context

[smyrick]

Add standard attributes to all LOGS from request/context

[BrynCooke]

Suggest we make the JSON formatter for logging have a section that specifies allowed attributes.

[smyrick]

@BrynCooke That would add the value to all spans, but it does not get included in all text logs from Router. I want all logs, including ones internal to the Router debugging, to have some standard attributes

[BrynCooke]

In theory this should give you what you need:

telemetry:
  instrumentation:
    spans:
      mode: spec_compliant
      router:
        attributes:
          shanes-custom-correlation-id:
            request_header: "x-correlation-id"

Span attributes are included on log events under the span_list key.

Resources are intentionally static and are sent in the envelope of otel payloads rather than on individual events/traces/metrics

[smyrick]

Oh wait, I think I missed the key part there. There is a setting in the Router log configuration that allows you to include the span information IN the logs meaning that I can add standard attribute if they exist in the spans, correct?

https://www.apollographql.com/docs/router/configuration/telemetry/exporters/logging/stdout#json-configuration-reference

telemetry:
  instrumentation:
    spans:
      mode: spec_compliant
      default_attribute_requirement_level: recommended
       # Set values to add to all the different spans
      router:
        attributes:
          "shanes-custom-id":
            request_header: "x-shane-id"

  exporters:
    logging:
      stdout:
        enabled: true
        format:
          json:
            # Include span info in logs
            display_current_span: true
            display_span_list: true

Does this only get included as part of the standard router, supergraph, and subgraph spans though? What about logs that happen during query planning?

[smyrick]

One down side to this current configuration option is that is still logs all the span attributes which could be quite large. If I just need one header value to exist in the logs, and ideal configuration as proposed could be a lot smaller and use less resources

[BrynCooke]

Yeah, span list contains all the span data for all nested spans. I could see us adding something to allow more targeted attributes here.

[abernix]

@bnjjj Does this tie into any other work?

[bnjjj]

@abernix no I don't think so

[BrynCooke]

It could be solved with this #5387