Giter Site home page Giter Site logo

Comments (8)

jerielng avatar jerielng commented on August 17, 2024 4

@SangChan @Jaechan-So Thanks for this extra information! This will be helpful in testing out the fix to ensure that it covers your cases as well!

from appboy-ios-sdk.

jerielng avatar jerielng commented on August 17, 2024 4

Hi all, we've just released version 4.5.3, which should resolve these crashes!

from appboy-ios-sdk.

hokstuff avatar hokstuff commented on August 17, 2024 3

Hi @SangChan,

We have identified a fix on the Appboy SDK that should address the root cause of your issue, which should allow you to continue using your current implementation. We will post back here once the patch is released.

from appboy-ios-sdk.

hokstuff avatar hokstuff commented on August 17, 2024 1

Hi @SangChan,

In your step 3 3) of your steps to repro, it sounds like your application is doing the unsafe command of typecasting an unknown field to the incorrect type, which causes our SDK to crash. In version 4.5.2, we added improved validation for trigger properties to ensure that our SDK properly handles those fields.

  1. properties are typed by [String:Any], and price, currency, quantity are typecasted by known type through docs.

What class are you typecasting those fields to in your code? Based on the stack trace, the SDK expects an NSString during validation, which appears to be why the application is crashing. Can you remove any typecasts from your code and try testing again?

from appboy-ios-sdk.

SangChan avatar SangChan commented on August 17, 2024

Hi @hokstuff , nice to hear that.
I'm glad to wait for next release but already had a hard time to find way how to reproduce this for helping you guys.. ;(

I found clear steps to reproduce this issue for, will write below then.

If all of my team put this code on app delegate's did finish launch event, it may causes app's crashing on it.
no matter they already sent or not.

Not sure, but if I change event name from "composition_order_complete" to another, like "1" or "test", it never crashed.
Hopes, you guy solve this issue for it!

//////////////////////////////////////// --
let dict : Dictionary = [
"CouponAmount":0.0,
"PointAmount":0.0,
"cart_category":"ν˜Έν…”",
"cart_category_cnt":1,
"cart_package_discount":0.0,
"category":"ν˜Έν…”",
"check_in_date":"2023-01-30",
"check_out_date":"2023-01-31",
"composite_order_id":"Y230118XRPLB",
"cust_count":2,
"dayuse_included":false,
"has_children":false,
"is_earlybird":true,
"item_detail_id":"141849",
"item_detail_name":"Standard",
"item_id":"10006056",
"item_name":"QA λ¬Έ ν˜Έν…”2",
"paid_amount":30000,
"property_category":"HOTEL",
"use_type":"OVER_NIGHT",
"visitType":"도보"
] as [String : Any]

Appboy.sharedInstance()?.logCustomEvent("composition_order_complete", withProperties:dict)
//////////////////////////////////////////////// --

from appboy-ios-sdk.

Jaechan-So avatar Jaechan-So commented on August 17, 2024

Hello, we also got similar(and almost same) issue in our app. In addition to the information that @SangChan already provided, we noticed that the message in the exception Fatal Exception: NSInvalidArgumentException was

-[__NSCFNumber isEqualToString:]: unrecognized selector sent to instance {some_memory_address}

(which was displayed in Firebase Crashlytics). Hope this is helpful for solving issue! πŸ™

from appboy-ios-sdk.

Jaechan-So avatar Jaechan-So commented on August 17, 2024

Our team checked that the crash did not occur with version 4.5.3. Thank you for quick respond! 😊

from appboy-ios-sdk.

SangChan avatar SangChan commented on August 17, 2024

Look like it seems gone, Many thanks! πŸ™

from appboy-ios-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.