Giter Site home page Giter Site logo

Comments (11)

pks111607 avatar pks111607 commented on May 30, 2024

Did some further investigation. Turns out it is mandatory to have the [params.writers."Some Writer"] parameter in the configuration. My workaround for now is to set a dummy writer:

  [params.writers]
    [params.writers."Another Author"]
      link = "https://www.anotherauthor.com"
      email = "[email protected]"
      bio = [
        "Another author is a something</a>. This is the author bio shown after posts."
      ]
      facebook      = "full profile url in facebook"
      googleplus    = "full profile url in googleplus"
      twitter       = "full profile url in twitter"
      linkedin      = "full profile url in linkedin"
      stackoverflow = "full profile url in stackoverflow"
      instagram     = "full profile url in instagram"
      github        = "full profile url in github"
      pinterest     = "full profile url in pinterest"

Would it be possible to either make this a little clearer in the documentation, or change so that the params.writers.* is not necessary for the homepage to load correctly?

from hugo-nederburg-theme.

MatthewMcD avatar MatthewMcD commented on May 30, 2024

There is a related issue that the Author link in the Single.html does not show up if you are not using params.writers. This is not the case in Portfolio.html where the .Site.Params "authorlink" conditional works.

from hugo-nederburg-theme.

 avatar commented on May 30, 2024

Ok, better documentation is needed and one more iteration of this "feature"..

from hugo-nederburg-theme.

MatthewMcD avatar MatthewMcD commented on May 30, 2024

I have fixed this and one other bug I haven't reported related to categories with two words in my build. I'll submit a PR later today.

from hugo-nederburg-theme.

 avatar commented on May 30, 2024

Ok, perfect!

from hugo-nederburg-theme.

MatthewMcD avatar MatthewMcD commented on May 30, 2024

OK, by "later today"' I really meant "later..." hopefully this week.

from hugo-nederburg-theme.

agustinf avatar agustinf commented on May 30, 2024

"hopefully this year".. oh wait!

😄 I'm just kidding, but in case you have at least a partial fix, could you point me to it ?

from hugo-nederburg-theme.

MatthewMcD avatar MatthewMcD commented on May 30, 2024

Yikes, how bad am I at estimating. Let me re-fetch the code and get back to you.

from hugo-nederburg-theme.

MatthewMcD avatar MatthewMcD commented on May 30, 2024

OK, you can easily repro if you comment out the

[ params.writers ]

section of the config file (leaving the [params.social] intact). This causes the

[map]

to show up on the home page before every post.

I have traced it to the portfolio.html page and line 10:

07 {{ if .Site.Params.writers }}
08    {{ $scratch.Set "writer" (index .Site.Params.writers (lower .Params.writer) | default dict) }}
09  {{ else }}
10    {{ $scratch.Set "writer" .Site.Params.social | default dict }}
11  {{ end }}

I don't know how to debug this further. In my case I didn't "fix" it I just added a bogus [ params.writers ] entry. HTH

from hugo-nederburg-theme.

MatthewMcD avatar MatthewMcD commented on May 30, 2024

OK, I have this all fixed but in doing so I ran into something that could be interpreted as a bug, so before I submit a PR to fix this issue let me ask. If the author of the post leaves the writer empty in the post front matter like this:

writer = ""

What would the expected behavior be? It currently defaults to the Params.social fields and uses Params.social.email. If you remove the writer attribute all together it displays Params.email instead.

Tell me what you think and I'll submit the PR accordingly.

Cheers.

from hugo-nederburg-theme.

MatthewMcD avatar MatthewMcD commented on May 30, 2024

I opted to just document the behavior. PR Submitted.

from hugo-nederburg-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.