Giter Site home page Giter Site logo

[FR] RTL support about appflowy HOT 10 CLOSED

asafm avatar asafm commented on May 4, 2024 11
[FR] RTL support

from appflowy.

Comments (10)

notd5a-alt avatar notd5a-alt commented on May 4, 2024 3

I think this would be possible to implement once the developers implement their plugin system for the app.

from appflowy.

zoli avatar zoli commented on May 4, 2024 3

Now Appflowy Editor supports RTL. IMO the next step will be RTL support in Appflowy Board and Grid.

from appflowy.

zoli avatar zoli commented on May 4, 2024 1

It's very weird implementation. Usually if you are in Google Doc, or Word, you choose the LTR or RTL direction for the current paragraph. Many times it simply detects if the language is LTR and switches for you automatically - Facebook posts (when you create a new post) is a good example. It doesn't make a lot of sense to have one direction set for the entire app.

You can have auto direction detection when setting direction to AUTO. About the per-paragraph direction, I agree with you. This was available in Appflowy a while ago but now its limited to RTL layout direction, So If you set the layout direction to RTL you can set a paragraph direction to either LTR/RTL/AUTO.
I discussed with @LucasXu0 enabling per-paragraph direction in all layout directions we concluded to put a setting for enabling it in the toolbar menu for all layout directions.
The reason for not enabling it by default is because it might confuse some users.

from appflowy.

zoli avatar zoli commented on May 4, 2024

@annieappflowy If by plugin label you mean appflowy editors plugin, How this can be implemented via plugin? From what I see for supporting RTL in Appflowy document which is mostly related to appflowy editor core. Appflowy editor should enable setting textDirection on RichText which FlowyRichText builds it.

from appflowy.

zoli avatar zoli commented on May 4, 2024

Just noting some thoughts here:
Probably TextNode should support direction attribute which sets the RichText textDirection property.
There could be LTR, RTL, AUTO for TextNode direction attribute which could get determined by appflowy toolbar. As RichText doesn't support AUTO internally appflowy editor should handle that part itself (maybe with strong directionality concept).

from appflowy.

zoli avatar zoli commented on May 4, 2024

I would like to take on this.

cc: @annieappflowy

from appflowy.

annieappflowy avatar annieappflowy commented on May 4, 2024

Thank you!!

from appflowy.

annieappflowy avatar annieappflowy commented on May 4, 2024

@asafm, please try out the latest release

Toggle on the RTL switch in Settings to write in the RTL layout

Image

from appflowy.

zoli avatar zoli commented on May 4, 2024

@annieappflowy Still RTL support for board and grid is left.

from appflowy.

asafm avatar asafm commented on May 4, 2024

It's very weird implementation.
Usually if you are in Google Doc, or Word, you choose the LTR or RTL direction for the current paragraph. Many times it simply detects if the language is LTR and switches for you automatically - Facebook posts (when you create a new post) is a good example.
It doesn't make a lot of sense to have one direction set for the entire app.

from appflowy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.