Link libappimage statically

[appimagecommunity]

Link libappimage statically

[TheAssassin]

https://travis-ci.org/AppImage/appimaged/builds/390200745#L3114

Now that we don't build libappimage any more, we don't need to install it with CMake.

I still don't believe that installing an appimaged package was really necessary earlier, @probonopd.

[TheAssassin]

@azubieta this issue is about distributing libappimage for this specific app. We wouldn't discuss such things in any repo but AppImageKit.

[probonopd]

And, more importantly, so that one can install it by double clicking the deb, without having to install a deb for libappimage first

[TheAssassin]

Change libappimage_static for libappimage in the CMake configuration in src.

But I think libappimage is bundled by our packages, isn't it?

[TheAssassin]

And, more importantly, so that one can install it by double clicking the deb, without having to install a deb for libappimage first

I agree this is indeed an issue. Please implement the fix I suggested above, it'll link libappimage statically then.

[probonopd]

Build fails with

[100%] Linking C executable appimaged
/usr/bin/ld: ../lib/AppImageKit/src/libappimage_static.a(notify.c.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5'
//lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

now.

[probonopd]

This currently breaks https://github.com/probonopd/SystemImageKit/blob/master/boot/bin/generate-appimaged-extension.

Never touch a...

[TheAssassin]

Urm... interesting. I'll try this on my dev system later...

[azubieta]

Now that we don't build libappimage any more, we don't need to install it with CMake.

Are we going to keep building and installing libappimage from AppImageKit ?