Crash help text has mangled URL

[Edward-Knight]

Crash help text has mangled URL

[Edward-Knight]

Or actually, looking at the code further, is the URL missing a ?body=? So it should be https://github.com/apple/pkl/issues/new?body=java.lang.StackOverflowError?

[holzensp]

Fixed by PR #73

[Edward-Knight]

Although #73 will ensure the URL is always valid, I don't think it's a full fix. The next line tries to URL encode the error, presumably so it can be put in the title or body of the GitHub issue

is the URL missing a ?body=? So it should be https://github.com/apple/pkl/issues/new?body=java.lang.StackOverflowError?

[Edward-Knight]

Also should I open a separate issue about the stack overflow or is the current behaviour expected?

[holzensp]

The stack overflow is expected, although arguably it's missing a stack frame (cc @stackoverflow and not just for the ironically appropriate username). In Pkl, a = a is the simplest way to cause a stack overflow. That's essentially what you're doing here, because in output { value = output }, the inner output "ties a loop" with the outer output.

Re-opening to follow up about the query parts of the URL (which may have been rolled into the URL encoding fix)