Ship release 1.0.6

[lorentey]

Ship release 1.0.6

[lorentey]

Candidate commit:

• 03d60be
• 0791ab9
• d029d9d

Diff: 1.0.5...release/1.0

Given the sheer number of supported Swifts, I'll only be doing a tiny fraction of the full pre-release test matrix.

I'll skip Windows testing; I trust that the CMake build results on macOS & Linux indicate that Windows will pass too.

Testing progress:

macOS/AS

• macOS 14, Apple Silicon, Xcode 15.0.1 (Swift 5.11 dev snapshot)
• macOS 14, Apple Silicon, Xcode 15.0.1 (Swift 5.10 dev snapshot)
• macOS 14, Apple Silicon, Xcode 15.0.1 (Swift 5.9.2)
• macOS 14, Apple Silicon, Xcode 14.3.1 (Swift 5.8.1)
• macOS 14, Apple Silicon, Xcode 14.2 (Swift 5.7.2)
• macOS 14, Apple Silicon, Xcode 13.4.1 (Swift 5.6.1)
• macOS 14, Apple Silicon, Xcode 13.2.1 (Swift 5.5.2)
• macOS 14, Apple Silicon, Xcode 12.5.1 (Swift 5.4.2)
• macOS 14, Apple Silicon, Xcode 12.4 (Swift 5.3.2)

macOS/x86_64

• macOS 14, Intel x86_64, Xcode 15.0.1 (Swift 5.11 dev snapshot)
• macOS 14, Intel x86_64, Xcode 15.0.1 (Swift 5.10 dev snapshot)
• macOS 14, Intel x86_64, Xcode 15.0.1 (Swift 5.9.2)
• macOS 14, Intel x86_64, Xcode 14.3.1 (Swift 5.8.1)
• macOS 14, Intel x86_64, Xcode 14.2 (Swift 5.7.2)
• macOS 14, Intel x86_64, Xcode 13.4.1 (Swift 5.6.1)
• macOS 14, Intel x86_64, Xcode 13.2.1 (Swift 5.5.2)
• macOS 14, Intel x86_64, Xcode 12.5.1 (Swift 5.4.2)
• macOS 14, Intel x86_64, Xcode 12.4 (Swift 5.3.2)

Linux/Aarch64

• Ubuntu 20.04, Aarch64, Swift 5.11 dev snapshot
• Ubuntu 20.04, Aarch64, Swift 5.10 dev snapshot
• Ubuntu 20.04, Aarch64, Swift 5.9.2
• Ubuntu 20.04, Aarch64, Swift 5.8.1
• Ubuntu 20.04, Aarch64, Swift 5.7.3
• Ubuntu 20.04, Aarch64, Swift 5.6.3
  (Swift 5.6 was the first Swift that supported Aarch64 on Ubuntu)

Linux/x86_64

• Ubuntu 20.04, x86_64, Swift version 5.11-dev (LLVM 067380bceb10522, Swift 15a6c01a16e3465)
• Ubuntu 20.04, x86_64, Swift version 5.10-dev (LLVM 2d55bb6028127bf, Swift 766e653ae1d0268)
• Ubuntu 20.04, x86_64, Swift 5.9.2
• Ubuntu 20.04, x86_64, Swift 5.8.1
• Ubuntu 20.04, x86_64, Swift 5.7.3
• Ubuntu 20.04, x86_64, Swift 5.6.3
• Ubuntu 20.04, x86_64, Swift 5.5.3
• Ubuntu 20.04, x86_64, Swift 5.4.3
• Ubuntu 20.04, x86_64, Swift 5.3.3

Windows 10/x86_64

• Windows 10, x86_64, Swift 5.11 dev snapshot
• Windows 10, x86_64, Swift 5.10 dev snapshot
• Windows 10, x86_64, Swift 5.9.2
• Windows 10, x86_64, Swift 5.8.1
• Windows 10, x86_64, Swift 5.7.3
• Windows 10, x86_64, Swift 5.6.3
• Windows 10, x86_64, Swift 5.5.3
• Windows 10, x86_64, Swift 5.4.3
• Windows 10, x86_64, Swift 5.3.3

(Note: I expect most of this matrix will remain untested in this tag.)

[lorentey]

The 1.0.5..release/1.0 diffs look alright. I just want to look at some older Swifts on Linux before going ahead with the tag.

[lorentey]

Swift 5.3 doesn't like @unchecked Sendable:

  [83/92] Compiling OrderedCollections _UnsafeBitset.swift
  /source/swift-collections/Sources/OrderedCollections/OrderedSet/OrderedSet+Sendable.swift:12:24: error: unknown attribute 'unchecked'
  extension OrderedSet: @unchecked Sendable where Element: Sendable {}
                         ^
  /source/swift-collections/Sources/OrderedCollections/OrderedSet/OrderedSet+Sendable.swift:12:58: error: cannot find type 'Sendable' in scope
  extension OrderedSet: @unchecked Sendable where Element: Sendable {}
                                                           ^~~~~~~~
  /source/swift-collections/Sources/OrderedCollections/OrderedSet/OrderedSet+Sendable.swift:12:34: error: cannot find type 'Sendable' in scope
  extension OrderedSet: @unchecked Sendable where Element: Sendable {}
                                   ^~~~~~~~

[lorentey]

Heh, that's because OrderedSet's conformance doesn't have the usual condition around it: 🤦‍♂️

extension OrderedSet: @unchecked Sendable where Element: Sendable {}

[lorentey]

Fix landed in #346. Resuming tests without retrying previously successful runs. (I'm assuming the new change will not break those.)

[lorentey]

The CMake config appears to be missing a source file, and it leads to errors on 5.5+:

[04 cmake.build-with-ninja] ninja -C /tmp/run-full-tests.sh.s3YVt/cmake
  Failed in 2s. See /tmp/run-full-tests.sh.s3YVt/04.cmake.build-with-ninja.log for full console output.
      internal var _base: OrderedDictionary
                   ^
  /source/swift-collections/Sources/OrderedCollections/OrderedDictionary/OrderedDictionary+Elements+SubSequence.swift:95:18: error: stored property '_base' of 'Sendable'-conforming struct 'Iterator' has non-sendable type 'OrderedDictionary<Key, Value>'
      internal var _base: OrderedDictionary
                   ^
  /source/swift-collections/Sources/OrderedCollections/OrderedDictionary/OrderedDictionary+Elements.swift:18:18: error: stored property '_base' of 'Sendable'-conforming struct 'Elements' has non-sendable type 'OrderedDictionary<Key, Value>'
      internal var _base: OrderedDictionary
                   ^
  [2/3] Linking Swift static library lib/libDequeModule.a
  ninja: build stopped: subcommand failed.

It's quite embarrassing that I haven't caught this on arm64 🤔

[lorentey]

Huh, curiously it did succeed there:

[03 cmake.generate] cmake -S . -B /tmp/run-full-tests.sh.8aG9s/cmake -G Ninja
  Completed in 4s
[04 cmake.build-with-ninja] ninja -C /tmp/run-full-tests.sh.8aG9s/cmake
  Completed in 6s

[lorentey]

Ah, this is only a problem on 5.5. Evidently the conformances are inferred in 5.6+? Weird.

[lorentey]

#347 resolves this issue. Restarting full tests on x86_64/Ubuntu focal, incl. previously successful runs.

[lorentey]

OK, this is ready to go.

I think I'll forgo pre-announcing the new release; it seems unlikely we'd get any actual feedback even if something broke, and I don't want purely ceremonial delays.

[lorentey]

The release is out now: https://github.com/apple/swift-collections/releases/tag/1.0.6