Giter Site home page Giter Site logo

Comments (6)

Lukasa avatar Lukasa commented on September 24, 2024 1

+1 for BaggageModule.

from swift-distributed-tracing-baggage.

slashmo avatar slashmo commented on September 24, 2024 1

+1 on BaggageModule too.

from swift-distributed-tracing-baggage.

ktoso avatar ktoso commented on September 24, 2024

Paging @tomerd @weissi @Lukasa to discuss this one...

Originally when we prepared the packages we intentionally made the packages CoreBaggage which contains Baggage and Baggage which contains LoggingContext. It was deemed fine at the time, but seems we have an issue.

The baggage type will remain even with task local values present I think, although as usual it is "very hidden" and noone should need to touch it except a few tracer implementations.

So this is more about the LoggingContext being a name which may need disambiguation... though I'd argue others should not define their own LoggingContext and could call them MyFrameworkLoggingContext, which again solves the issue then.

I think we're also working to improve the namespacing issues if I remember correctly @tomerd ?

from swift-distributed-tracing-baggage.

ktoso avatar ktoso commented on September 24, 2024

We could do BaggageModule I guess similar to what stdlib team projects do https://github.com/apple/swift-collections/tree/main/Sources

from swift-distributed-tracing-baggage.

ktoso avatar ktoso commented on September 24, 2024

Sounds good -- could you send in a PR @fabianfett ? I'll tag a release then and update the dependency in the main tracing repo so noone should really notice the change in practice.

Thanks for noticing!

from swift-distributed-tracing-baggage.

slashmo avatar slashmo commented on September 24, 2024

Closed via #13, the module name is now InstrumentationBaggage.

from swift-distributed-tracing-baggage.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.