Comments (6)
+1 for BaggageModule
.
from swift-distributed-tracing-baggage.
+1 on BaggageModule
too.
from swift-distributed-tracing-baggage.
Paging @tomerd @weissi @Lukasa to discuss this one...
Originally when we prepared the packages we intentionally made the packages CoreBaggage
which contains Baggage
and Baggage
which contains LoggingContext
. It was deemed fine at the time, but seems we have an issue.
The baggage type will remain even with task local values present I think, although as usual it is "very hidden" and noone should need to touch it except a few tracer implementations.
So this is more about the LoggingContext
being a name which may need disambiguation... though I'd argue others should not define their own LoggingContext
and could call them MyFrameworkLoggingContext
, which again solves the issue then.
I think we're also working to improve the namespacing issues if I remember correctly @tomerd ?
from swift-distributed-tracing-baggage.
We could do BaggageModule
I guess similar to what stdlib team projects do https://github.com/apple/swift-collections/tree/main/Sources
from swift-distributed-tracing-baggage.
Sounds good -- could you send in a PR @fabianfett ? I'll tag a release then and update the dependency in the main tracing repo so noone should really notice the change in practice.
Thanks for noticing!
from swift-distributed-tracing-baggage.
Closed via #13, the module name is now InstrumentationBaggage
.
from swift-distributed-tracing-baggage.
Related Issues (9)
- Merge Final API proposal after reviews conclude
- Remove LoggingContext and BaggageCore HOT 2
- Compilation fails on Swift 5.5 [known issue until Xcode ships with macOS 12 SDK] HOT 5
- Access control per baggage item key HOT 2
- requiring Sendable from Baggage is source breaking HOT 8
- Update README according to Final API HOT 1
- Consider renaming module/repo to something that doesn't mention distributed tracing/instrumentation HOT 6
- `Baggage.$current.withValue` vs `Baggage.withValue` and actors HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-distributed-tracing-baggage.