Giter Site home page Giter Site logo

Comments (2)

allevato avatar allevato commented on June 22, 2024

Your assumption that this is intended is correct; we treat where clauses as being on "equal footing" as the original declaration, because of situations like these:

class SomeClass<T, U, V>:
  SomeSuperclass,
  SomeProtocol,
  SomeOtherProtocol
where
  T.SomeAssociatedType == Foo,
  U.SomeOtherThing == V
{
} 

This indentation clearly delimits the section of inheritances/conformances from generic constraints, whereas indenting the where keyword would blend them (which can be seen in the changes to the tests in your PRs), and also introduce an (IMO) unnecessary level of indentation in front of the entire section.

Since there's no "official/default/recommended" Swift style, if you'd like to continue pursuing your PRs then we're happy to explore alternative approaches, but since the current style applied by the formatter is being depended on by folks using it in production, any explicit style changes (rather than bug fixes) to that style will need to be placed behind a configuration option that is false by default.

from swift-format.

swift-ci avatar swift-ci commented on June 22, 2024

Comment by Yusuke Kita (JIRA)

If that's the case, I'm totally okay with current format.

I think adding a new option in the configuration would be an alternative approach. However, I would like to hold until we get more demand from others to avoid adding unuseful option. I'll close this ticket

from swift-format.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.