Comments (5)
Yuck. The intent here was to fix unnecessary uses of class
and struct
as a namespace, but this is definitely a valid usage. Even if we did something like "look recursively for uses of self
", that wouldn't catch a situation where there might be only-external references to the class.
I think struct
-> enum
should still be fine? But then I wonder if the rule continues to hold its weight. Maybe we should consider abandoning this one.
from swift-format.
I think maybe we should leave it the way it is and just expect users to opt out if they have a breakage like this? We have other cases in our codebase where we're doing this from other files so no matter what we wouldn't detect those
from swift-format.
I believe pretty strongly that the formatter should not break any code under any circumstances. If a user is opting out of a rule, it should be for syntactic reasons, not to work around a transform that's so aggressive that it can't detect valid use cases.
from swift-format.
Sounds good, I think your suggestion will work then
from swift-format.
This was fixed by #18.
from swift-format.
Related Issues (20)
- Formatting results in duplicated top-level documentation HOT 2
- [Question] Can I strict the order of Closure annotation? HOT 1
- [Bugs?] `await` keyword mistake order when I use Swift-testing library. HOT 5
- Function to find and remove ASCII art from block comments is too finicky HOT 4
- Create a rule to add a specific format to file headers HOT 2
- Whitespace linting rules cannot be disabled HOT 9
- Error building swift-format in a Docker container HOT 6
- Typed throws in do blocks formatted incorrectly HOT 1
- Error building swift-format in a Docker container - Reopen HOT 3
- Ignoring a rule on a variable declaration doesn't work HOT 4
- `OrderedImports` sometimes moves import before file header HOT 6
- Rule for putting annotations into separate lines HOT 1
- AllPublicDeclarationsHaveDocumentation doesn't check enums, actors, or nested declarations HOT 1
- swift-format bug formatting nested #if #else #endif nodes in switch statement HOT 1
- Re-indenting multiline string literal with multiline tertiary expression fails HOT 2
- Existing line breaks between attributes are not removed respectsExistingLineBreaks == false HOT 1
- Support `.editorconfig` HOT 4
- Special case macros? HOT 4
- `multiElementCollectionTrailingCommas` adds comma to line comment when element is a ternary operator
- Attributes merged without space
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-format.