WIndows: INSTALLDIR's permission seems not right.

[apple]

WIndows: INSTALLDIR's permission seems not right.

[compnerd]

Unfortunately, the space in Program Files is non-negotiable.

I know; but that also means that it is currently something that is not worth fighting over. Using the alternate path allows focus on the other larger issue of tool stability and quality. Once those are settled, I think going over the codepaths with a fine tooth comb to find any possible issues where the spaces could be a problem (e.g. VFS computation, name computation, etc).

[wjk]

If you move the INSTALLDIR somewhere under C:\Program Files, I understand that Windows would then apply those permissions automatically.

Besides, it looks like this exact change is currently being implemented in #139.

[compnerd]

@wjk hmm, I don't see how that PR changes the permissions or the location (it merely renames swift to Swift). The runtime was moved into ProgramFiles a while ago. The toolchain remains under C:\Library as the default (for now). But, I do agree with this in principle - the toolchain image should not be mutable by NT AUTHORITY\Authenticate Users.

[wjk]

I don't see how that PR changes the permissions or the location

My apologies. I confused what you were changing with what was already there. I would recommend moving the toolchain under ProgramFiles as well.

[compnerd]

I don't see how that PR changes the permissions or the location

My apologies. I confused what you were changing with what was already there.

No worries; that PR is also not mine :)

I would recommend moving the toolchain under ProgramFiles as well.

I'd like to do that some day. However, the name is an issue - if we can rename Program Files to ProgramFiles perhaps - I really would prefer not having the space in the path at this point where the path handling is already not very robust.

[wjk]

Unfortunately, the space in Program Files is non-negotiable.