Giter Site home page Giter Site logo

Revisit isEmpty methods about swift-protobuf HOT 2 CLOSED

apple avatar apple commented on September 7, 2024
Revisit isEmpty methods

from swift-protobuf.

Comments (2)

jcanizales avatar jcanizales commented on September 7, 2024 1

<Standard reminder that adding stuff later if there's demand is always possible, but removing isn't.>

from swift-protobuf.

tbkka avatar tbkka commented on September 7, 2024

I think the generated isEmpty is only still being used in one case: the equality test on messages uses it to ensure that a message with no allocated storage class is considered equal to one where the storage class is allocated but "empty."

An alternative approach would be to always allocate the backing storage object. Then this case never arises. Empty objects (allocated but with no fields set) should be uncommon, so I don't see a big drawback. It would also simplify the uniqueStorage() implementation.

from swift-protobuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.