Comments (2)
<Standard reminder that adding stuff later if there's demand is always possible, but removing isn't.>
from swift-protobuf.
I think the generated isEmpty
is only still being used in one case: the equality test on messages uses it to ensure that a message with no allocated storage class is considered equal to one where the storage class is allocated but "empty."
An alternative approach would be to always allocate the backing storage object. Then this case never arises. Empty objects (allocated but with no fields set) should be uncommon, so I don't see a big drawback. It would also simplify the uniqueStorage()
implementation.
from swift-protobuf.
Related Issues (20)
- Package Resolution Failed in Xcode 15.3 HOT 1
- Can I use SwiftProtobufPluginLibrary or SwiftProtobuf as a Protobuf-parser in Swift project? HOT 1
- The "thread" sanitizer testing is failing HOT 8
- The fuzz regression tests seem to have stopped working. HOT 2
- Need to Add a Privacy Manifest for Apple Validation store for sprint 2024 HOT 1
- Add a PrivacyInfo file HOT 1
- TextFormat seems like it might not be to spec for "inf", "infinity", or "nan" HOT 2
- PR approved back in July 2022 and changes still not included in a release HOT 7
- Unable to verify code signature when installing app to iOS from XCode HOT 4
- Primitive one-of type always passes nil as its argument for decoder HOT 8
- Serialization is not generated HOT 8
- Support for Protobuf Editions HOT 2
- Un-revert breaking changes before releasing v2
- Consider support for newer concepts like `BitwiseCopyable` HOT 1
- SwiftProtobuf.xcodeproj cannot be opened because it is missing its project.pbxproj file. HOT 4
- New `CodeGenerator` protocol should allow customising the `Google_Protobuf_Compiler_CodeGeneratorRequest` HOT 7
- SwiftProtobufPluginLibrary.FileDescriptor.proto is deprecated HOT 13
- xCode shell script doesn't run HOT 6
- Breaking change in `1.27.0` HOT 3
- error in readme HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-protobuf.