Giter Site home page Giter Site logo

Comments (5)

tbkka avatar tbkka commented on June 28, 2024

I think your comment only applies to proto3?

In proto2, oneof fields are optionals, and we map proto2 optionals to Swift optionals, so the default value in that case is nil.

Oh. I suppose proto2 optionals can have explicit default values? I don't think I've seen that case, but that would make sense as well.

from swift-protobuf.

thomasvl avatar thomasvl commented on June 28, 2024

You can also have a message in the oneof, so returning the default there to dot into the default fields also is useful.

from swift-protobuf.

tbkka avatar tbkka commented on June 28, 2024

You can also have a message in the oneof, so returning the default there to dot into the default fields also is useful.

Yes, good point. Are there examples of this in the google/protobuf/unittest_* protos? If so, then it should be easy to fill in some tests for these cases.

from swift-protobuf.

thomasvl avatar thomasvl commented on June 28, 2024

Yup - https://github.com/google/protobuf/blob/master/src/google/protobuf/unittest.proto#L177

from swift-protobuf.

thomasvl avatar thomasvl commented on June 28, 2024

PR #119 added tests to confirm this got fixed in PR #102

from swift-protobuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.