Giter Site home page Giter Site logo

Comments (2)

tmcdonell avatar tmcdonell commented on June 2, 2024

Correction, it seems like using a freestanding declaration method never worked either. I just tested the example from #72307 and that also executes the defer statement immediately (swift-5.9-release). Same as if I change this example to a declaration macro.

@i2h3 if I just add some print statements to your example I get the following:

> swift run
Building for debugging...
[8/8] Linking SignpostClient
Build complete! (1.49s)
Signpost begin: sayHello()
Signpost defer: sayHello()
Hello!

Did you also encounter this behaviour (in your larger application)?

Edit: For completeness, here is the diff:

diff --git a/Sources/SignpostMacros/SignpostMacro.swift b/Sources/SignpostMacros/SignpostMacro.swift
index c5fb8a8..b9a3677 100644
--- a/Sources/SignpostMacros/SignpostMacro.swift
+++ b/Sources/SignpostMacros/SignpostMacro.swift
@@ -10,9 +10,11 @@ public struct SignpostMacro: DeclarationMacro {
                 stringLiteral: """
                 let signpostID = signposter.makeSignpostID()
                 let signpostIntervalState = signposter.beginInterval(#function, id: signpostID)
+                print("Signpost begin: \\(#function)")
 
                 defer {
                     signposter.endInterval(#function, signpostIntervalState)
+                    print("Signpost defer: \\(#function)")
                 }
                 """
             ),

from swift.

tmcdonell avatar tmcdonell commented on June 2, 2024

According to the description of how macros are expanded, it seems that point (3) is not accurate; the compiler does not replace the macro call with its expanded form, rather it puts the expansion in a sub-tree and replaces the call with that. The diagram above this list also seems to imply the expansion should happen inline, but that doesn't appear to be the behaviour I am observing. Or, am I just doing something wrong? Any advice?

from swift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.