Giter Site home page Giter Site logo

Comments (8)

gustavla avatar gustavla commented on July 20, 2024

The pypi files for 4.0 permit more than we support. Even if we fix this for say 4.0.1, users on unsupported platforms would still get 4.0 if they simply did pip install turicreate. Of course, we never want to change 4.0, but we might be able to consider a name change of the files for 4.0 that simply will prevent users on unsupported platforms to get broken installs.

from turicreate.

znation avatar znation commented on July 20, 2024

The work here is twofold:

  • Build a wheel, instead of an egg, for Linux.
  • Remove the 4.0 egg so that users on unsupported platforms don't get that one on pip install.

Open question: should we backport this fix to 4.0 and publish a 4.0 wheel for Linux? Not sure if this is even possible on PyPI.

from turicreate.

gustavla avatar gustavla commented on July 20, 2024

I think you can remove old versions, but you can't re-upload them (maybe twine can circumvent, but I'm not sure). It looks we will probably need to pull version 4.0 from pypi at some point in the future, or issues where users try to install on an unsupported platform will never be fixed:

  • #121 Windows user outside WSL
  • #22 macOS 10.11
  • non-x86_64: I haven't seen a report of this yet, but theoretically this would not fail gracefully

from turicreate.

TobyRoseman avatar TobyRoseman commented on July 20, 2024

@gustavla - twine does not allow you to circumvent that.

from turicreate.

gustavla avatar gustavla commented on July 20, 2024

@TobyRoseman Good to know (I read some vague reference at pypa/packaging-problems#74 to suggest otherwise, but reading it again I think you are right). We'll probably have to pull it at some point in time then.

from turicreate.

znation avatar znation commented on July 20, 2024

@gustavla @TobyRoseman Another option would be to publish a newer version of a pure Python egg named turicreate, along with our future releases, but instead of containing a non-working version of Turi Create, it could error out on setup with a user-facing message re: platform/version support?

from turicreate.

gustavla avatar gustavla commented on July 20, 2024

@znation That would work, yes. I think that's probably our best solution given the circumstances, unless we are willing to remove 4.0 from PyPI soon after the next release comes out.

from turicreate.

znation avatar znation commented on July 20, 2024

4.2 egg with error message on install has been published to https://pypi.python.org/pypi/turicreate/4.2

from turicreate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.