Newline on end of file

[markijbema]

Newline on end of file

[markijbema]

@jeremyruppel @jjoos @bmarini @badquanta @LukeWinikates opinions?

(I'd like to change this, but only if this would be a universal good idea)

[kytrinyx]

I'm open to putting a newline on the end of the file, but it would break all existing tests, so there should be some sort of heads-up when upgrading. We're not at 1.0 yet, which means that all changes are acceptable, per http://semver.org

[markijbema]

Yups, that's why i mentioned it now ;)

[jjoos]

Adding a configuration option to trigger the old behavior would be nice for backwards compatibility.

RSpec.configure do |c|
  c.approvals_without_new_line_on_eof = true
end

[kytrinyx]

@jjos - that's a great idea. We can definitely do that.

[markijbema]

I made a pull-request. I did not implement such a backwards compatibility feature (yet), since I think it has little inherent value, and the value for backwards compatibility is limited. Approvals already ignores whether there is a newline at the end of the approval, so as long as the approvals don't change, you don't have to change anything. As soon as the approval changes, the line at the end of file also appears. I think that given that this doesn't break in any way, this is backwards compatible enough, given that we're still pre-1.0.

[kytrinyx]

I've merged the pull request, and released a new version of the gem. Thanks for the contribution!

[markijbema]

Cool, thanks!