Comments (5)
My idea for a quick fix is by deleting the token to force the user login again to get a new access token and refresh token.
For the exception, I try to remove it because there's no way to handle it when using this package. Dio Interceptor won't rethrow the DirectusError.
Future<AuthResponse?> manuallyRefresh() async {
...
try {
...
} catch (e) {
currentUser = null;
tfa = null;
tokens = null;
await _emitter.emitAsync('logout', null);
client.unlock();
return null;
}
...
}
from directus-dart.
I'm not sure if we should logout user on error. But it's definitely a bug if we can't handle exception.
manuallyRefresh
should not ignore errors, since user can call that method directly, and is a problem if instead of a new access token, he/she was logged out.
I think the problem is with the interceptor, it's his job to handle errors.
What do you think about this? It should properly throw error, but I haven't tested it yet.
// Inside `refreshExpiredTokenInterceptor`
// line 174
try {
final response = await manuallyRefresh();
if (response?.accessToken != null) {
options.headers['Authorization'] = response!.accessToken;
} else {
options.headers.remove('Authorization');
}
} catch (e) {
return handler.reject(DioError(requestOptions: options, error: e));
}
from directus-dart.
When I think about it again, I agree with you. We shouldn't immediately log out the user. I didn't think thoroughly earlier.
Yeah, I think it's a good idea to let manuallyRefresh
still throw Exception. But the Exception from it is DirectusError
, can it be converted back to DioError
? (I don't know about that).
I'll try testing your solution and make some tests around it.
from directus-dart.
Not currently, but we can add DioError? dioError
property, since most of the errors are from http, and assign it when using fromDio
constructor. Can you open a PR?
from directus-dart.
Closed in #29
from directus-dart.
Related Issues (20)
- Solution: createMany() throws an error "Problem with Directus". HOT 2
- `sdk.fields` doesn't work with new api HOT 2
- How to get custom user fields? HOT 2
- Expose transport like JS SDK HOT 2
- fix items -> updateMany HOT 2
- refresh token interceptor bug fix HOT 2
- Unhandled Exception: type 'String' is not a subtype of type 'int' of 'index' HOT 4
- Auth Refresh fails and soft locks users out of the system HOT 4
- Deep Filter for translations HOT 5
- Making AuthResponse public so as to use this: "directus.auth.storage.storeLoginData(data)" HOT 1
- How do you Sign up a new user from the SDK HOT 1
- Broken link in code documentation HOT 4
- Upgrade the packages to Dart 3.0 HOT 2
- Why there is a Flutter Dependency in Directus Dart Package for shared_preferences? HOT 4
- Create a Flutter Project in example of `directus` package
- SSO support
- Example of using typedItems with subentities
- Real time subscription
- Support for SSO and OAuth login
- Please export the ItemsHandler
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from directus-dart.