Comments (3)
Using pyqt's QThread may also solve this problem, some examples already exist within the codebase, and they allow for UI feedback from thread events.
from hyperdome.
Making the network requests async will only change things if the UI is also async, which isn't supported well with PyQT5.
Options:
- Make networking and UI both async. UI code will be messier.
- Make networking async and have UI run in a separate thread, which will make networking faster when there are multiple IO operations happening at once, which will rarely happen ever.
- Keep networking blocking, have UI run in separate thread.
Option 3 is cleaner than option 1, and almost as fast as option 2, but it'd be multithreaded. PyQT5 has issues with running in any thread other than the main, so that's gross.
I'm working on option 1 now, to see how complicated it'd be.
from hyperdome.
New plan:
Have a second thread to do the networking, and have it dispatch callbacks to the main UI thread that deal with updating UI elements.
from hyperdome.
Related Issues (20)
- Use Queues for server message lists to ensure ordering and synchronization HOT 1
- Werkzeug and Stem not respecting log levels HOT 1
- Use websockets for chat
- Change signal binding on HyperdomeClient
- Support multiple counselor adding policies
- Tray icon shows after exit
- Add server peering/counselor key sharing for servers
- Change all references to onionshare/micahflee in edited files
- Implement config CLI along with refactor of configuration adding more relevant options
- refactor server API to be more RESTful and use JSON over HTTP forms
- implement unit tests and run all tests target to test for regressions
- Impement test coverage check and achieve 100% test coverage HOT 1
- Allow KeyboardInterrupt exception to be handled with threads
- Consistant capitalization in prints and logging messages HOT 1
- implement queue for guests in server
- Implement an extended diffie-helmen exchange to protect against possible man-in-the-middle attacks HOT 1
- use a bonafide datastore to make inter-request data process/thread safe HOT 1
- Replace ShutdownTimer class with threading.Timer
- Evaluate replacing Fernet symmetric cryptography with ChaCha20Poly1305 HOT 1
- "Test Tor" button in settings causes a crash
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyperdome.