Giter Site home page Giter Site logo

Comments (6)

jimmydorry avatar jimmydorry commented on July 24, 2024

The array would make the most sense, as long as it is properly documented.

from node-dota2.

rjackson avatar rjackson commented on July 24, 2024

I think this has been completed in #90. Can anybody confirm?

from node-dota2.

howardchung avatar howardchung commented on July 24, 2024

@pyarmak added it, I think. I've never tried to use it myself.

from node-dota2.

Crazy-Duck avatar Crazy-Duck commented on July 24, 2024

The method was added, but it has fixed arguments. Might want to refactor it to take 1 filter argument instead, kinda like lobbies.

from node-dota2.

Crazy-Duck avatar Crazy-Duck commented on July 24, 2024

I've put a rework on my dev branch. I externalized the option parser from the configureLobby method in a separate file -> handlers/helper.js. createPracticeLobby, configureLobby and getPlayerMatchHistory all use this method to parse their input arguments. I made sure that all obligatory arguments are required on their respective interfaces.

from node-dota2.

Crazy-Duck avatar Crazy-Duck commented on July 24, 2024

This issue can be closed I think, modification has been merged some weeks ago

from node-dota2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.