Comments (5)
Hey! Can you test and see if force loading a thinkpad_acpi solves this issue? To do it you'd need to create a thinkpad-acpi.conf file in /etc/modprobe.d that contains "options thinkpad_acpi force_load=1" without quotes, after that reboot your machine and test again. If this won't work we can try to manually control this via conf file.
from coreboot.
Regarding thinkpad_acpi:
While testing, I realized that thinkpad_acpi has issues detecting the EC version of a T440p running coreboot. I found, that thinkpad_acpi expects a specially formatted SMBIOS version string. In other ThinkPads this is achieved by prepending the string "CBET4000" to the coreboot version when reading the SMBIOS version. This is done in src/drivers/i2c/at24rf08c/lenovo_serials.c and I guess the T440p is not using this EEPROM driver. I fixed this, by integrating the SMBIOS version function into the mainboard.c of the T440p, like it was once done in coreboot before the code got moved to the EEPROM driver (see commit 537283d).
The thinkpad_acpi module now correctly detects the EC version, but this had no influence on the backlight issue.
Edit: I just checked something. Fixing this issues resolves the necessity to force_load thinkpad_acpi. The module now loads automatically without any additional parameters.
from coreboot.
The thinkpad_acpi module now correctly detects the EC version, but this had no influence on the backlight issue.
Edit: I just checked something. Fixing this issues resolves the necessity to force_load thinkpad_acpi. The module now loads automatically without any additional parameters.
The issue with the EC not being detected also impacts tlp charging / calibration thresholds as the tpacpi-bat returns error that the device is not supported.. Most probably this would also be fixed by the change done by @dwzg Unfortunately my keyboard won't arrive until at least end of next week :/
from coreboot.
I got the backlight to work! Writing 0x05 to the address 0x01 in ectool does the trick for me. After this I can control the backlight with Fn+Space, like on a noncorebooted T440p. Still no clue where this problem comes from and how to fix it permanently.
from coreboot.
Backlight is fixed now: https://review.coreboot.org/c/coreboot/+/38650
from coreboot.
Related Issues (15)
- No start possible since version 1.2 HOT 5
- Headphone jack HOT 2
- Can't build today. Some issues with submodules. HOT 6
- T440p sd card reader not working HOT 1
- Issues building cross-compiler even though gcc-ada installed HOT 2
- Tianocore not booting HOT 1
- pcieport device [8086:8c12] error HOT 1
- build-uefi.sh "toolchain for x86_32 architecture was not found' HOT 1
- Build error: conflicting types for 'smmstore_read_region' HOT 1
- Build error: Could not add payload ... too big? HOT 1
- Crystallwell support HOT 10
- ectool adresses for battery thresholds
- How to add the intel microcode now? HOT 2
- Boot options not saved HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coreboot.