Invalid or corrupt jarfile scanner_cli.jar

[quincik]

Invalid or corrupt jarfile scanner_cli.jar

[phodal]

哈哈，@ariesfly 可以参考上面的提交修复 877eaf8

看了一下应该是 : 导致的问题，需要 encode 一下，目测会自动 decode

[phodal]

看看这个 jar 是不是正常的？诸如于：检查从 GitHub 的下载情况？

[quincik]

断点了下，可以下载 ，isInstalled(fileName) 返回时 true

另外下载的 版本是：https://github.com/archguard/archguard/releases/download/v2.0.0-beta.2/scanner_cli-2.0.0-beta.2-all.jar

[phodal]

isInstalled 是 spec 里的，是需要其它 jar 的，比如 lang_csharp-2.0.0-beta.2-all.jar 之类的

[quincik]

有什么日志会有打印出来，看下具体信息么？

[phodal]

[SCANNER] org.archguard.scanner.ctl.Runner <cli parameters> 
|type: SOURCE_CODE 
|systemId: 0 
|serverUrl: http://localhost:8080 
|workspace: . 
|path: . 
|output: [json] 
<customized analysers> 
|analyzerSpec: [] 
|slotSpec: [] 
<additional parameters> 
|language: kotlin 
|features: [datamap] 
|repoId: null 
|branch: master 
|startedAt: 0 
|since: null 
|until: null 
|depth: 7 
[SCANNER] o.a.s.ctl.loader.AnalyserLoader workspace path: /home/parallels/Desktop/demo
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser install path: /home/parallels/Desktop/demo/dependencies/analysers
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser: rule-webapi - [2.0.0-beta.5] is installed
[SCANNER] o.a.scanner.ctl.loader.SlotHubImpl register slot: rule-webapi
[SCANNER] o.a.s.ctl.loader.AnalyserLoader workspace path: /home/parallels/Desktop/demo
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser install path: /home/parallels/Desktop/demo/dependencies/analysers
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser: rule-test - [2.0.0-beta.5] is installed
[SCANNER] o.a.scanner.ctl.loader.SlotHubImpl register slot: rule-test
[SCANNER] o.a.s.ctl.loader.AnalyserLoader workspace path: /home/parallels/Desktop/demo
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser install path: /home/parallels/Desktop/demo/dependencies/analysers
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser: rule-sql - [2.0.0-beta.5] is installed
[SCANNER] o.a.scanner.ctl.loader.SlotHubImpl register slot: rule-sql
[SCANNER] o.a.s.ctl.loader.AnalyserLoader workspace path: /home/parallels/Desktop/demo
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser install path: /home/parallels/Desktop/demo/dependencies/analysers
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser: kotlin - [2.0.0-beta.5] is installed
[SCANNER] o.a.scanner.ctl.loader.SlotHubImpl found output type: chapi.domain.core.CodeDataStruct
[SCANNER] o.a.scanner.ctl.loader.SlotHubImpl try plug slot for: org.archguard.linter.rule.testcode.TestSmellRuleSlot@1f1d416f
[SCANNER] o.a.scanner.ctl.loader.SlotHubImpl done plug slot for: org.archguard.linter.rule.testcode.TestSmellRuleSlot@1f1d416f
[SCANNER] o.a.scanner.ctl.loader.SlotHubImpl found output type: org.archguard.rule.core.Issue
[SCANNER] o.a.s.ctl.loader.AnalyserLoader workspace path: /home/parallels/Desktop/demo
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser install path: /home/parallels/Desktop/demo/dependencies/analysers
[SCANNER] o.a.s.ctl.loader.AnalyserLoader analyser: datamap - [2.0.0-beta.5] is installed 

[quincik]

2023-02-15 16:10:56.899 [DefaultDispatcher-worker-2 @coroutine#1] INFO c.t.a.s.infra.ScannerCliClient - [SCANNER] o.a.s.ctl.client.ArchGuardHttpClient process topic: sca-dependencies
2023-02-15 16:10:56.900 [DefaultDispatcher-worker-2 @coroutine#1] INFO c.t.a.s.infra.ScannerCliClient - Exception in thread "main" java.net.URISyntaxException: Illegal character in query at index 86: http://localhost:8080/api/scanner/3/reporting/sca-dependencies?language=kotlin&path=C:\Users\zhenlin\AppData\Local\Temp\archguard15652771582882474328
2023-02-15 16:10:56.900 [DefaultDispatcher-worker-2 @coroutine#1] INFO c.t.a.s.infra.ScannerCliClient - at java.base/java.net.URI$Parser.fail(URI.java:2913)

找到了些详细的 Exception in thread "main" java.net.URISyntaxException 这个是什么问题？

[phodal]

应该是 Windows 下生成的 path 有问题，导致 new URI 出错了：

archguard/scanner_cli/src/main/kotlin/org/archguard/scanner/ctl/client/ArchGuardHttpClient.kt

Lines 57 to 60 in b06bb8b

	private inline fun <reified T> process(topic: String, body: T) {
	logger.info("process topic: $topic")
	process(URI(buildUrl(topic)), body)
	}

[quincik]

确实 是windows 环境，这个该如何改下？

[phodal]

理论上应该对 path 进行 encode：

archguard/scanner_cli/src/main/kotlin/org/archguard/scanner/ctl/client/ArchGuardHttpClient.kt

Lines 39 to 40 in b06bb8b

	private fun buildUrl(topic: String) =
	"$serverUrl/api/scanner/$systemId/reporting/$topic?language=$language&path=$path"

在对应分析 path 的地方进行 decode。

不过，现在运行的方式有点奇怪，理论上 ArchGuard Server 应该是部署在类 Unix 环境下的。如果在 Windows 下运行的话，path 一般是等于 . 的。

[quincik]

目前调研下产品就 本地了，window是麻烦 不过 手上没Mac。 哎

[phodal]

这个路径是用来 debug 用的，并不是很重要。你可以

1. 修改本地的 scanner_cli 然后本地构建一下就可以了
2. 或者先不用 sca 这种类型的 scanner（注释掉 42 行）：

archguard/server/src/main/kotlin/com/thoughtworks/archguard/smartscanner/StranglerScannerExecutor.kt

Lines 36 to 53 in b06bb8b

	private fun Scanner.scanWith(context: ScanContext) {
	// TODO just delete and remove the disabled scanner
	if (!canScan(context)) return
	val command = when (this) {
	is SourceCodeScanner -> [e-mail](context, AnalyserType.SOURCE_CODE)
	is ScaScanner -> [e-mail](context, AnalyserType.SCA)
	is DiffChangesScanner -> [e-mail](context, AnalyserType.DIFF_CHANGES)
	is GitSourceScanner -> [e-mail](context, AnalyserType.GIT)
	else -> null
	}
	// TODO call multiple analyser in one call with DAG config
	if (command == null) scan(context)
	else {
	log.debug("found new implementation of ${this.javaClass}, execute command: $command")
	scannerClient.send(command)
	}
	}

[quincik]

重新构建 注释后 扫描报

2023-02-15 16:47:59.279 [pool-1-thread-1] INFO c.t.a.s.i.command.Processor - Already up to date.
Exception in thread "DefaultDispatcher-worker-1 @coroutine#1" kotlin.NotImplementedError: An operation is not implemented: deprecated, replace with StranglerScannerExecutor.run(context, SCA)
at com.thoughtworks.archguard.scanner.domain.scanner.codescan.sca.ScaScanner.scan(ScaScanner.kt:12)
at com.thoughtworks.archguard.scanner.domain.scanner.codescan.sca.ScaScanner.scan(ScaScanner.kt:7)

另外，同样还是出现了

Exception in thread "main" java.net.URISyntaxException: Illegal character in query at index 78:

[quincik]

已经解决了 tks