Giter Site home page Giter Site logo

Comments (5)

ctalkington avatar ctalkington commented on August 23, 2024

for some reason, it would appear that it ignores the level passed to it. will just enforce STORE when level is zero. patch in the works.

from node-archiver.

torpeanders avatar torpeanders commented on August 23, 2024

It only ignores it when level is 0, right? I see differences in the file size when I pass it different levels, but 0 gives me the same size as the default level of 6.

from node-archiver.

ctalkington avatar ctalkington commented on August 23, 2024

from what I can tell, yes. not quite sure why it doesn't treat zero proper as its even in the zlib docs but then again node's zlib isn't perfect. i tend to leave at level 1 (which is just speed).

Compression levels.
#define Z_NO_COMPRESSION         0
#define Z_BEST_SPEED             1
#define Z_BEST_COMPRESSION       9
#define Z_DEFAULT_COMPRESSION  (-1)

from node-archiver.

torpeanders avatar torpeanders commented on August 23, 2024

1.5 hour from reported bug to working fix is not bad. Thanks 👍

FYI: I did a python testcase just to confirm that the problem was not in my zlib, and level 0 worked correctly there.

from node-archiver.

ctalkington avatar ctalkington commented on August 23, 2024

published to npm as v0.4.5. let me know if have any other issues.

from node-archiver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.