Comments (5)
for some reason, it would appear that it ignores the level passed to it. will just enforce STORE when level is zero. patch in the works.
from node-archiver.
It only ignores it when level is 0, right? I see differences in the file size when I pass it different levels, but 0 gives me the same size as the default level of 6.
from node-archiver.
from what I can tell, yes. not quite sure why it doesn't treat zero proper as its even in the zlib docs but then again node's zlib isn't perfect. i tend to leave at level 1 (which is just speed).
Compression levels.
#define Z_NO_COMPRESSION 0
#define Z_BEST_SPEED 1
#define Z_BEST_COMPRESSION 9
#define Z_DEFAULT_COMPRESSION (-1)
from node-archiver.
1.5 hour from reported bug to working fix is not bad. Thanks 👍
FYI: I did a python testcase just to confirm that the problem was not in my zlib, and level 0 worked correctly there.
from node-archiver.
published to npm as v0.4.5
. let me know if have any other issues.
from node-archiver.
Related Issues (20)
- Class extends value undefined is not a constructor or null HOT 1
- Is there a way to know how many files were ultimately compressed? HOT 2
- Question: Were there any API changes from 5.3 to 6.x? HOT 1
- Recommendation for an unzip library? HOT 1
- Overwrite existing files
- Missing Release of Resource after Effective Lifetime [High Severity] HOT 1
- zlib level 0 stops the progress of ongoing read streams
- Improve docs around append callback? HOT 1
- How to convert csv to 7z HOT 1
- Heap out of memory with archiver.append() HOT 1
- Append CSV file line by line
- `append()` fails after upgrading from v6 to v7 HOT 4
- Cannot add file named `\` HOT 2
- Archiver Version 7.0 might be breaking due to ESM HOT 1
- [Question] Can this library work with Web Streams ?
- Create a single zip file incrementally? HOT 1
- Produce the same zip file all time HOT 1
- Zip file produced has 0 bytes HOT 2
- ZIP consume all memory and return null from lambda function response
- docs should warn loudly that archiver doesn't use bonafide Node streams
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-archiver.