zip: issues with unzip on mac os

[archiverjs]

zip: issues with unzip on mac os

[ctalkington]

it would also be helpful if you could clone or zip download this repo and run "npm test" from root of it. and see if you get same issues with those zips.

[ctalkington]

would need to be actual source, so something like

wget https://github.com/ctalkington/node-archiver/archive/master.zip
unzip master.zip
npm install
npm test

zips would then be in tmp folder of working dir

[ctalkington]

yep, CRC fails for me too. could you post a package.json stripped down to just deps? that way i can try to archive the exact same for comparison. also the compress config you used would be good too just to eliminate as much as possible.

[ampgcat]

I tried 'unzip -t' on all zip files in tmp/ and none had an error.

[ampgcat]

I've sent you the files you asked for (package.json and gruntfile.js that includes the uncompress commands I used). If you need anything else, please let me know. Thanks. :)

[ctalkington]

hum, never got them, could you send them directly to email. having issues with Google Drive account lately.

[ampgcat]

But, do you still need the file?
I didn't see the errors any more when I tried it with your patched source..
Miwako

2013/7/7 Miwako [email protected]

Well.. I can't because it's over 25 MB...

2013/7/7 Chris Talkington [email protected]

hum, never got them, could you send them directly to email. having issues
with Google Drive account lately.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/34#issuecomment-20578701
.

[ctalkington]

sorry, meant the "package.json and gruntfile.js" so that i can try to recreate from scratch.

what do you mean by "patched source"?

[ampgcat]

Hi.
By 'patched source', i meant the one you wanted me to download, i.e. you
said

it would also be helpful if you could clone or zip download this repo and
run "npm test" from root of it. and see if you get same issues with those
zips.

[ampgcat]

I'm resending grauntfile.js / package.json.

[ctalkington]

hum, had to fix paths in gruntfile but it creates zip without issue for me. granted its not your full project but did do all the node_modules. could you maybe do the following in your project and try generating zip you had issues with before?

npm cache clean
npm install
grunt compress

[ampgcat]

Sorry it took long.
Yes I did try the command sequences and am getting the same error.

unzip -t app.nw > /dev/null
->
error: invalid compressed data to inflate
file #xxxx: bad zipfile offset (local header sig): yyyyyyyy

2013/7/7 Chris Talkington [email protected]

hum, had to fix paths in gruntfile but it creates zip without issue for
me. granted its not your full project but did do all the node_modules.
could you maybe do the following in your project and try generating zip you
had issues with before?

npm cache clean
npm install
grunt compress

[image: image]https://f.cloud.github.com/assets/209757/759455/4df76d38-e78a-11e2-83d4-d7ddf420ce0b.png

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/34#issuecomment-20585641
.

[ctalkington]

does it open in macs archive tool either? does it always start in the same place?

[ampgcat]

Hi.
No, mac archive tool (zip) works correctly.It doesn't always seem to start in the same place.
First time:
file #2329: 15871075
file #2330 : 15871426 ...

Second time:
file #14832: 44462110
file #14833: 44466480...

Third time:
file #8616: 30777629
file #8617: 30778533...

[ampgcat]

Chris.
Summarizing what we've done after this..
I updated node to v0.10.12 and tried the gruntfile.js / package.json you gave me and the zip created did not contain any error. But when I tried my project (after fresh npm install etc), it still gave the same error.

[ctalkington]

@ampgcat im pretty sure this falls under #32 now. I did get a sample from the poster that I was able to recreate and I just made some changes to how are offsets are tracked which seems to get rid of the "bad zipfile offset" but now in that issue I found that i end up "invalid compressed data to inflate" on windows.anyways this issue is moving to other ticket to consolidate.