Callback doesn't get called creating large ZIPs

[archiverjs]

Callback doesn't get called creating large ZIPs

[ctalkington]

does testing the archive with winrar (think its a feature) say anything?

technically, if you pipe to res you shouldnt need to call res.end() as it should get emitted to the res via pipe. I haven't used archiver in such ways but most that do haven't reported any issues yet, not to say there isn't one. It typically comes down to the way its used and platform.

[ctalkington]

I do have this gist, that shows a similar process, albeit not from S3.

https://gist.github.com/ctalkington/5734444

[jValdron]

Alright, what's weird is that it used to work well before. And testing your gist, that process works flawlessly. So I'll dig around and figure out what's my problem.

EDIT: By the way, Winrar test feature just says that the archive is corrupted.

[jValdron]

Alright, all my fault, sorry about that. I was not loading the S3 files correctly. Here's the code I'm using now:

s3.get(__path__).on('response', function(res){

    var buffer = new Buffer(parseInt(res.headers['content-length'], 10));

    res.on('data', function(chunk){
        buffer.addChunk(chunk); // See node-bufferjs for addChunk.
    });

    res.on('end', function(){

        archive.append(buffer, {
            name: __name__
        }, callback);

    });

}).end();

Thanks for your help!

[ctalkington]

Glad you worked it out!