Tar not working when archive empty files

[archiverjs]

Tar not working when archive empty files

[ctalkington]

going to need a code sample and environment information. there are tests for such things which all currently pass.

[cevek]

os x 10.9. Just try append some empty files to tar archive.

On 9 November 2013 03:31, Chris Talkington [email protected] wrote:

going to need a code sample and environment information. there are tests
for such things which all currently pass.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-28106912
.

[ctalkington]

sorry, i don't have a mac to test on.

what version of node? archiver? how are you adding the file (stream or buffer)? if stream, what kind legacy or stream2?

[sethkinast]

I'll be more helpful than that guy!

Mac OS X 10.7
Node 10.22
Archiver 0.5.0-alpha

var archive = archiver('tar');
archive.pipe(res); // I'm in Express
archive.append(fs.createReadStream(path.resolve("path", "to", "emptyFile.txt")), { name: "empty.txt" });

res.set('Content-Disposition', 'attachment; filename=empty.txt');
archive.finalize();

Fails silently without throwing an error (the finalize() callback is never invoked, and archive.on('error') is not invoked either.

[ctalkington]

wouldn't you set content-disp before pipe? as it could be sending data before you define what it is?

[ctalkington]

hum, i think the test has multiple appends, maybe the first one kick starts the thing and single doesn't. will have to play with it next time im editing things.

[sethkinast]

I had assumed that nothing was actually sent until finalize() was called, since it seemed to work fine. I moved the Content-Disposition setter but it had no effect on the output, it seems.

My actual code does do multiple appends, which doesn't work either, unfortunately. The empty file is the last file appended-- I tried changing the order so that the empty file came first, and that didn't change anything.

The actual code in my app:

files.forEach(function(f) {
    archive.append(fs.createReadStream(path.resolve(CONTENT_DIR, f)), { name: f });
});

[sethkinast]

Unrelated: this is the best, easiest node package for tarring and zipping out there, thanks :)

[ctalkington]

you could actually use file now too with latest alpha. let it handle the stream creating for you.

[ctalkington]

glad you like the package. v0.5 is going to really redefine the internals of it all with tar and zip logic being switched to modules internally. zip-stream and tar-stream will be integrated in the coming weeks which should allow for quick targeted fixes to output related issues without need to update archiver itself.

[sethkinast]

So using .file() actually works, and the zero-byte file is included correctly!

[ctalkington]

ah so my guess is that stream emits before archiver can handle it.