Giter Site home page Giter Site logo

Comments (3)

stancl avatar stancl commented on June 12, 2024

I see, seems like the HasDomains trait should be using something like BelongsToTenant::$tenantIdColumn as well instead of the literal tenant_id string.

We changed this in v4 to use a config key instead of a trait property, since PHP 8.1 shows deprecation notices when you try to access trait properties (#854): 24146b2

But I see your point that this relates to HasDomains as well, and not just single-db Tenancy traits/columns.

The change you proposed to BelongsToTenant seems to be fully implemented here already (correct me if I'm wrong): 24146b2#diff-3f95188061d3fafb597105f47adbb923c98d5b4da9a9839c4a944627c5277981R17-R27

And for the HasDomains trait, you can currently just override the method, but I agree that we should add a config key.

from tenancy.

stancl avatar stancl commented on June 12, 2024

Thanks for opening the issue!

from tenancy.

scaabel avatar scaabel commented on June 12, 2024

I see, seems like the HasDomains trait should be using something like BelongsToTenant::$tenantIdColumn as well instead of the literal tenant_id string.

We changed this in v4 to use a config key instead of a trait property, since PHP 8.1 shows deprecation notices when you try to access trait properties (#854): 24146b2

But I see your point that this relates to HasDomains as well, and not just single-db Tenancy traits/columns.

The change you proposed to BelongsToTenant seems to be fully implemented here already (correct me if I'm wrong): 24146b2#diff-3f95188061d3fafb597105f47adbb923c98d5b4da9a9839c4a944627c5277981R17-R27

And for the HasDomains trait, you can currently just override the method, but I agree that we should add a config key.

Thanks @stancl .

from tenancy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.