Comments (3)
I see, seems like the HasDomains
trait should be using something like BelongsToTenant::$tenantIdColumn
as well instead of the literal tenant_id
string.
We changed this in v4 to use a config key instead of a trait property, since PHP 8.1 shows deprecation notices when you try to access trait properties (#854): 24146b2
But I see your point that this relates to HasDomains
as well, and not just single-db Tenancy traits/columns.
The change you proposed to BelongsToTenant
seems to be fully implemented here already (correct me if I'm wrong): 24146b2#diff-3f95188061d3fafb597105f47adbb923c98d5b4da9a9839c4a944627c5277981R17-R27
And for the HasDomains
trait, you can currently just override the method, but I agree that we should add a config key.
from tenancy.
Thanks for opening the issue!
from tenancy.
I see, seems like the
HasDomains
trait should be using something likeBelongsToTenant::$tenantIdColumn
as well instead of the literaltenant_id
string.We changed this in v4 to use a config key instead of a trait property, since PHP 8.1 shows deprecation notices when you try to access trait properties (#854): 24146b2
But I see your point that this relates to
HasDomains
as well, and not just single-db Tenancy traits/columns.The change you proposed to
BelongsToTenant
seems to be fully implemented here already (correct me if I'm wrong): 24146b2#diff-3f95188061d3fafb597105f47adbb923c98d5b4da9a9839c4a944627c5277981R17-R27And for the
HasDomains
trait, you can currently just override the method, but I agree that we should add a config key.
Thanks @stancl .
from tenancy.
Related Issues (20)
- Tenant could not be identified on domain 127.0.0.1 HOT 1
- Possible performance issues with central queues? HOT 2
- Issue with global cache HOT 1
- Issue with the cache in multithread HOT 2
- Queued Notifications are not tenant aware and produces wrong Action links HOT 2
- tenants:run with jobs combined with queue:work keeps multiple database connections open HOT 12
- SQLSTATE[HY000] [2002] Connection refused
- bug in Request data identification HOT 1
- any_name.host_name shows my tenant landing page HOT 1
- Tenant cannot be created HOT 1
- i can't getting any data from users table HOT 2
- Additional (foreign ID) column not updated in Tenant table HOT 2
- migrate-fresh command don't consider mysql-schema.dump file HOT 13
- Random Database [central] not configured errors HOT 10
- Cache::increment('key'); return null HOT 10
- Weird dates in sqlite tenant database HOT 3
- Caching the existance of a tenants database HOT 2
- Help: Tenant schedule HOT 1
- Laravel spatie permissions issue HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tenancy.