Comments (3)
I made the network parameter optional. The network parameter is not mentioned in the documentation and should probably not be trusted as always being available. The user implementing the callback can use the fields he/she is interested in, but I am not sure allowing a user to override the required fields will be beneficial. It opens the door to the user specifying fields that won't exist or making spelling/format mistakes. The only required fields are now the ones that the documentation states should always be passed. If this fails, there is something wrong with the Clickatell system.
from clickatell.
Give it a try on master. I will tag it as soon as you confirm it's working for your needs.
from clickatell.
Looks good! Thanks.
from clickatell.
Related Issues (19)
- Missing query message by cliMsgId HOT 4
- Method signature compatibility error in Clickatell\ClickatellEvent::getMessageCharge() HOT 3
- Special characters get mangled HOT 11
- Parameter 4 is required and does not default to HTTP HOT 3
- ClickatellRest - Response is never returned on error HOT 3
- Character encoding
- Scheduled delivery HOT 1
- Git branching & Composer HOT 3
- The sendMessage method returns empty array
- Licenses mismatch HOT 1
- Can i send send bulk message? HOT 2
- Use of `mo` parameter HOT 3
- Using this package or from clickatell org? HOT 2
- Problem with transitive dependencies detect
- Clickatel changed their return message HOT 2
- Api.php - callApi has some issues HOT 1
- concat param for sendMessage() allowing the message to expand over more smses. HOT 1
- Concat parameter for longer than 140 char messages HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clickatell.