Comments (3)
Hi @mpickers,
We might do this. There is no need to throw an exception, that method won't exist at all in the EF6 package. It will reference the netstandard2.0
TFM of Ardalis.Specification
, and we have excluded this method in the interface for this TFM.
#if NET6_0_OR_GREATER
IAsyncEnumerable<T> AsAsyncEnumerable(ISpecification<T> specification);
#endif
Probably we can do this change for the next release. We just have to think once again whether we're breaking any consumer.
from specification.
Hey @mpickers,
I just tested. We can't target netstandard2.1
. Consumers will face runtime issues. For instance, if you consume the libraries from .NET6
, and you have the following code (which you must have actually), then you'll face a peculiar issue. Since the base package targets .NET6
the AsAsyncEnumerable
method in the interface will be enabled. On the other hand, the EF6
package compiled in .netstandard2.1
won't see it and the repo implementation will compile without it. Hence on runtime, you'll get an exception.
public class Repository<T> : RepositoryBase<T> where T : class
{
public Repository(TestDbContext dbContext) : base(dbContext)
{
}
}
Anyway, we can target NET6
for EF6
package. In that case, indeed we have to throw NotImplementedException
.
Are you ok with this?
from specification.
@fiseni Yes, that would be perfect, thanks.
Yes, I can see the peculiar happenings and have seen it in other migrations I've done, hence I suggested targeting net6. The netstandard2.1 comment was just stating that EF6 was "able" to be used by net6 projects.
from specification.
Related Issues (20)
- Update LangVersion to C# 10 or 11
- Update conventions and styling
- Update Sample projects
- Remove obsolete API
- Update pipelines.
- Including nullable/optional navigation property causes only non-nullable connected objects to be returned HOT 3
- Unable to apply Take() to a navigation property HOT 5
- Refactor and improve integration test fixtures.
- Why do the Update and Delete not returning anything? HOT 3
- Logging in the Package HOT 4
- Feature Request: Deletion of entities via specification HOT 5
- Shadow properties HOT 4
- Query to return anonymous type HOT 4
- Question: Can I some how join table "B" when my entity T does not have a navigation property to "B" ? HOT 2
- Expression Evaluation HOT 8
- Simplify Cache usage HOT 5
- DbSet<T>.WithSpecification together with ISpecification<T, TDestination> throws SelectorNotFoundException HOT 4
- Conceptual question about the ORM specific implementations HOT 2
- Is it possible to use generic repository approach like this? HOT 1
- Specification - Include with Where clause HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from specification.