devDependencies vs. dependencies?

[aredridel]

devDependencies vs. dependencies?

[aredridel]

jsdom is definitely a dependency. npm can handle this, if it's installed as part of jsdom, npm will see that jsdom is already there. (It only installs sub-dependencies if the versions conflict and it doesn't exist in a parent's node_modules)

[aredridel]

tap is a devDependency

[aredridel]

bench is a devDependency

[aredridel]

opts I'm going to have to look at and refresh my memory

[domenic]

I can't find where you do require("jsdom")...

[aredridel]

lib/html5/parser.js: jsdom = require('jsdom')

[aredridel]

html5 parsing inherently requires a DOM (since it re-orders and reparents elements, it's not fully streamable), so I've depended on jsdom explicitly. It could be softened if there was another viable DOM to use, but there's not that I'm aware of. (envjs was crazypants last time I looked)

[domenic]

Ah, it was hiding in the middle of the file, I see. OK, no problem. In theory a decoupled interface would be nicer, but in practice it doesn't matter, since as you point out there's no other viable DOMs, and npm handles the circularity just fine.

[aredridel]

Yeah. It's on the wishlist, and I'm totally open to it the moment there's another DOM someone wants to even attempt using.

[danyaPostfactum]

Is this issue fixed?

[aredridel]

I think it is.