Giter Site home page Giter Site logo

Comments (13)

austinmatherne-wk avatar austinmatherne-wk commented on July 18, 2024 1

Thanks, Chad. I'm able to replicate the issue. I suspect that the viewer overriding the keepOpen setting is responsible for the issue here.

@paulwarren-wk can you remind me why that's needed for multi-instance viewers?

from ixbrl-viewer.

paulwarren-wk avatar paulwarren-wk commented on July 18, 2024 1

Thanks, Chad. I'm able to replicate the issue. I suspect that the viewer overriding the keepOpen setting is responsible for the issue here.

@paulwarren-wk can you remind me why that's needed for multi-instance viewers?

It's so that we can do the viewer creation all in one go at the end (on CntlrCmdLine.Filing.End), in order to avoid polluting the controller object with state from our plugin. I think you said that there was precedent for doing this in other plugins, so we should be able to switch to that approach and drop the use of keepOpen.

from ixbrl-viewer.

austinmatherne-wk avatar austinmatherne-wk commented on July 18, 2024

Hi Chad,

Thanks for the additional details. I may have misunderstood your email. Is the filing in your second request a multi inline document filing, or is it combing the inline documents from both the first and second requests in the response of the second request?

from ixbrl-viewer.

michaelchadfleming avatar michaelchadfleming commented on July 18, 2024

HI Austin,

Both input zips are single instance ESMA filings. I'll email over the zips because they're too big for GitHub's 25 MB restriction.

from ixbrl-viewer.

michaelchadfleming avatar michaelchadfleming commented on July 18, 2024

Hi Austin, I wasn't able to share via email either. I attached files for the smaller, first filing. Here's a link to the larger filing: https://filings.xbrl.org/filing/969500FU4DRAEVJW7U54-2023-12-31-ESEF-FR-0

output_1.zip
input_1.zip

from ixbrl-viewer.

austinmatherne-wk avatar austinmatherne-wk commented on July 18, 2024

We specifically support it in ValidateXbrl for validation plugins. We can add something similar to the cntlr, but need to make sure it's cleaned up after the last plugin hooks run (the ValidateXbrl plugin data is cleaned up automatically after validation).

from ixbrl-viewer.

paulwarren-wk avatar paulwarren-wk commented on July 18, 2024

That sounds like it should work. I think we would process each document in CntlrCmdLine.Xbrl.Run, and the write out the viewer and cleanup data in CntlrCmdLine.Filing.End.

from ixbrl-viewer.

austinmatherne-wk avatar austinmatherne-wk commented on July 18, 2024

I opened Arelle/Arelle/pull/1154. Once that's merged ixbrl-viewer should be able to implement and use it's own PluginData dataclass and drop the keepOpen argument.

from ixbrl-viewer.

michaelchadfleming avatar michaelchadfleming commented on July 18, 2024

Thank you both for looking into this :)

from ixbrl-viewer.

paulwarren-wk avatar paulwarren-wk commented on July 18, 2024

Hang on - we haven't actually done the work on the iXBRL viewer side yet.

We should re-open this issue, but I don't seem to have the permissions to do so.

from ixbrl-viewer.

michaelchadfleming avatar michaelchadfleming commented on July 18, 2024

Sorry about that. I reopened the issue.

from ixbrl-viewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.