Comments (7)
I believe this is caused by
which causes the provider matches method to not compare the should value for the attributes to the is value of the attributes if the is value is nil, which is the case if the tag exists but does not have attributesfrom xml_fragment.
I will try and review this in the next week.
from xml_fragment.
@rpolley You were spot on. Adding a check for the case where the definition has attributes defined but the existing element doesn't have any. Tested it on my end and it appears to work, but go ahead and pull from the development branch and give if a go before I package it up.
from xml_fragment.
@rpolley Bump
from xml_fragment.
@Areson - can you merge this in? i don't think we need to wait on rpolley as long as you tested it and it works. I've been waiting for this fix as well.
from xml_fragment.
@Areson seconding this, @1WindowsPuppetAdmin is probably in a better position than I am to validate that this works anyway.
from xml_fragment.
I've released the updated version on the forge. Thanks for your patience.
from xml_fragment.
Related Issues (10)
- Parser Syntax Error HOT 2
- Doc error, plus problems with getting xpath spec to work HOT 8
- Unable to insert xml node if it already exists in xpath HOT 5
- Package new release for Puppet Forge HOT 4
- Duplicates, then newer versions fail HOT 11
- When using `purge` file is overwritten on every puppet run HOT 5
- XML Quoting Request HOT 2
- Unwanted attributes not removed HOT 1
- New release with Puppet 7 compatibility? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xml_fragment.