Giter Site home page Giter Site logo

Comments (6)

smpark7 avatar smpark7 commented on July 22, 2024

image

CHI values here to show that the differences are significant.

from moltres.

smpark7 avatar smpark7 commented on July 22, 2024

Also, I'm not sure about SCALE output format and whether it has the same issue.

from moltres.

katyhuff avatar katyhuff commented on July 22, 2024

The actual problem is not quite what you have described here.
The correction is made, appropriately, if accounting for delayed neutrons with the approach:

$$\Chi_p = (1-\beta) \Chi_d$$

We do this in the if block related to _account_delayed.

As discussed in our meeting, though, we should probably do this individually for each group, though... That's a separate issue.

from moltres.

smpark7 avatar smpark7 commented on July 22, 2024

It should be that because the values I provided above show that for some groups, , while for others. If the equality were true, \chi^p_g should always be smaller than \chi^t_g because (1-\beta) is always less than 1.

Instead, from the Stacey Nuclear Reactor Physics textbook (equation 16.20a) and Alex's paper, the fission source term for neutron group g should be

The current implementation of CoupledFissionKernel for neutron group g with _account_delayed = true is:

.

The implementation differs from the standard formulation by the type of \chi terms used.

from moltres.

gridley avatar gridley commented on July 22, 2024

Hey @smpark7, I don't know if you ever fixed this, but I just had to do the math on this for another project and thought I'd share my result with you. You're definitely correct that the current approach is incorrect. If there is a separate delayed neutron emission spectrum for each delayed group, the relation should be

image

Where the subscript j indexes all the delayed neutron groups. This confirms what you're saying. Sorry that this was not put in correctly. I may have written that code... so, apologies!

from moltres.

smpark7 avatar smpark7 commented on July 22, 2024

Hi @gridley, I have not implemented a fix for this but it should be a relatively simple task of swapping the CHI_T's for CHI_P's under a conditional that checks whether CHI_D data exists. I will self-assign this as a backlog task to be completed in the next week or so but feel free to make the changes if you want to jump in earlier.

from moltres.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.