Comments (2)
Hi, I added the pydantic.v1
namespace to pydantic==1.10.15
and effectively broke your code. I'll briefly explain the motivation for the change and how you can fix this issue on your end.
Before this PR it was a bit tricky to write Pydantic code which is compatible with both v1 and v2 while robustly satisfying type checkers and linters. As a result some extended codebases had to pin Pydantic to v1. With the introduction of pydantic.v1
inside pydantic==1.10.15
one can write from pydantic.v1 import ...
and it'll work in both versions. Migrate your entire v1 codebase to this style and you will be able to release the version pin. Now compatible with pydantic>=2
, you can organically migrate v1-style code to v2-style in your own time.
Now onto your issue. Instead of checking for the existence of pydantic.v1
- which is no longer a differentiator of versions - check the value of pydantic.VERSION
instead.
from hera.
Incidentally this is the reason our CI checks have suddenly started failing for pydantic v1. We install poetry run pip install "pydantic<2"
which wasn't expected to change again until pydantic/pydantic#9042
from hera.
Related Issues (20)
- New dag/steps decorators issues/inconsistencies
- Add argo linting for examples
- Add runner debug mode for extra logging HOT 1
- Artifact name should be optional for runner inputs
- Custom serialization for non-user types and non-serializable types for Hera runner HOT 1
- Cannot run script with tuple annotation in return type HOT 1
- Arguments do not build correctly when using a dict
- DAGs/Steps cannot be added to TemplateSets
- Validate Input/Output class for new decorator functions at build time
- Locally-runnable DAG breaks down for complex examples
- Support Literal types in script runner
- Mypy call-arg errors when using script decorator HOT 7
- Mypy misc error using new Workflow/TemplateSet decorators
- Difficult to use script functions in fully type-safe code
- Fields silently ignored in Pydantic I/O types HOT 1
- Cannot output a non-serialisable Artifact using Pydantic IO HOT 2
- Allow using Pydantic I/O in with-based code HOT 2
- Docs need some tidying up
- Add an end-to-end script runner example
- Input/Output artifacts are not supported in dag HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hera.