Giter Site home page Giter Site logo

Comments (2)

exs-dmiketa avatar exs-dmiketa commented on September 22, 2024 2

Hi, I added the pydantic.v1 namespace to pydantic==1.10.15 and effectively broke your code. I'll briefly explain the motivation for the change and how you can fix this issue on your end.

Before this PR it was a bit tricky to write Pydantic code which is compatible with both v1 and v2 while robustly satisfying type checkers and linters. As a result some extended codebases had to pin Pydantic to v1. With the introduction of pydantic.v1 inside pydantic==1.10.15 one can write from pydantic.v1 import ... and it'll work in both versions. Migrate your entire v1 codebase to this style and you will be able to release the version pin. Now compatible with pydantic>=2, you can organically migrate v1-style code to v2-style in your own time.

Now onto your issue. Instead of checking for the existence of pydantic.v1 - which is no longer a differentiator of versions - check the value of pydantic.VERSION instead.

from hera.

elliotgunton avatar elliotgunton commented on September 22, 2024

Incidentally this is the reason our CI checks have suddenly started failing for pydantic v1. We install poetry run pip install "pydantic<2" which wasn't expected to change again until pydantic/pydantic#9042

from hera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.