Currently GitHubNotification have no other option than taking RepoURL from app.spec.source.repoURL

[argoproj]

Currently GitHubNotification have no other option than taking RepoURL from app.spec.source.repoURL

[sbx0r]

Hi @ryota-sakamoto.
Sure!

Notifications for github repositories are using spec.source.repoURL key from an application manifest here.
I would be glad if I could to modify this behaviour eg. by using metadata.annotations (like in slack service).
This would really improve our cicd pipelines when so can install helm chart via argo and notify some custom github repository (eg. source-code repo).

Would it be possible to you?

[tback]

I can provide the/a use case for this issue:

I have separate repositories for the application (a node app) and operation (a repository containing a helm chart in my case). I use an ApplicationSet fed by the PullRequestGenerator to deploy preview environments. I want to inform users (other developers, qa, product) about the state of the preview environment through the status in the PR. Obviously, the PR is in the application repository that is monitored by the generator, not in the operations repository configured in the application template.

The github notifier however has a fix repoURL (

notifications-engine/pkg/services/github.go

Line 46 in 4d8552b

repoURLtemplate = "{{.app.spec.source.repoURL}}"

).

A better name for this issue would be: Allow configuration of RepoURL and revision for GitHubNotification.

[ryota-sakamoto]

Would you provide more details?