Giter Site home page Giter Site logo

Comments (13)

arielfaur avatar arielfaur commented on May 13, 2024

I thought about this, but it would clutter the module and increase the codebase all of that for the sake of testing on the dev machine. I guess it is more important to keep the codebase to a minimum and avoid any issues related to performance... just an idea. What do you think?

from ionic-audio.

eminos avatar eminos commented on May 13, 2024

I don't know how much extra code that would be, probably not that much (?). But in that case the best solution would be to have an "plugin module for fallback", maybe with a "fallback" directive, to extend the normal functionality with that fallback (if that's possible at all?) during development.

from ionic-audio.

arielfaur avatar arielfaur commented on May 13, 2024

I'm just scared this module is already more than 400 lines of code, we'll need minification :)
But I will look into that.

from ionic-audio.

leonardosalles avatar leonardosalles commented on May 13, 2024

@arielfaur I think you can separete the module of HTML5 audio, and it can be removed with a cordova hook when we make the build, so you will only need to include the module and the javascript of HTML5 audio, like 'ionicAudio.HTML5Mock' and remove it when it is not on the dev. I can work on this feature and submit a pull request, sounds good for you?

from ionic-audio.

arielfaur avatar arielfaur commented on May 13, 2024

It was on my roadmap too. But go ahead and submit a pull request!

from ionic-audio.

leonardosalles avatar leonardosalles commented on May 13, 2024

Sure, I will implement the way that I mention

from ionic-audio.

Narayon avatar Narayon commented on May 13, 2024

The HTML5 Audio implementation is really small. Take a look at this:
goo.gl/SwFVga
Besides that, why should we use the Cordova Media plugin instead of the HTML5 Audio element or even the Web Audio API? Is it more performant? More options?

from ionic-audio.

arielfaur avatar arielfaur commented on May 13, 2024

@Narayon It's on the TODO list!

from ionic-audio.

benedyktdryl avatar benedyktdryl commented on May 13, 2024

@arielfaur can I help you with this? You have any concept of "how to implement this"? Just want to create fasade/proxy service which will decide what strategy use for playing audio?

from ionic-audio.

phishy avatar phishy commented on May 13, 2024

@Narayon Because on iOS the HTML5 Audio element doesn't work in the background without the cordova media plugin.

@arielfaur The description of this repo is misleading. It says it uses HTML audio as fallback. I can't see any mention it, unless I'm missing it?

from ionic-audio.

arielfaur avatar arielfaur commented on May 13, 2024

@phishy The HTML audio fallback is for v2! Sorry if the description is misleading. The v2 is on a separate branch though.

from ionic-audio.

tbergeron avatar tbergeron commented on May 13, 2024

Inactive issue? Can we close this?
This is already working in v2 and v3 if I'm not mistaken.

from ionic-audio.

arielfaur avatar arielfaur commented on May 13, 2024

@tbergeron Yes, let's close it.

from ionic-audio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.