Comments (13)
I thought about this, but it would clutter the module and increase the codebase all of that for the sake of testing on the dev machine. I guess it is more important to keep the codebase to a minimum and avoid any issues related to performance... just an idea. What do you think?
from ionic-audio.
I don't know how much extra code that would be, probably not that much (?). But in that case the best solution would be to have an "plugin module for fallback", maybe with a "fallback" directive, to extend the normal functionality with that fallback (if that's possible at all?) during development.
from ionic-audio.
I'm just scared this module is already more than 400 lines of code, we'll need minification :)
But I will look into that.
from ionic-audio.
@arielfaur I think you can separete the module of HTML5 audio, and it can be removed with a cordova hook when we make the build, so you will only need to include the module and the javascript of HTML5 audio, like 'ionicAudio.HTML5Mock' and remove it when it is not on the dev. I can work on this feature and submit a pull request, sounds good for you?
from ionic-audio.
It was on my roadmap too. But go ahead and submit a pull request!
from ionic-audio.
Sure, I will implement the way that I mention
from ionic-audio.
The HTML5 Audio implementation is really small. Take a look at this:
goo.gl/SwFVga
Besides that, why should we use the Cordova Media plugin instead of the HTML5 Audio element or even the Web Audio API? Is it more performant? More options?
from ionic-audio.
@Narayon It's on the TODO list!
from ionic-audio.
@arielfaur can I help you with this? You have any concept of "how to implement this"? Just want to create fasade/proxy service which will decide what strategy use for playing audio?
from ionic-audio.
@Narayon Because on iOS the HTML5 Audio element doesn't work in the background without the cordova media plugin.
@arielfaur The description of this repo is misleading. It says it uses HTML audio as fallback. I can't see any mention it, unless I'm missing it?
from ionic-audio.
@phishy The HTML audio fallback is for v2! Sorry if the description is misleading. The v2 is on a separate branch though.
from ionic-audio.
Inactive issue? Can we close this?
This is already working in v2 and v3 if I'm not mistaken.
from ionic-audio.
@tbergeron Yes, let's close it.
from ionic-audio.
Related Issues (20)
- Adjust speed of playing track HOT 2
- Structure of this._audioProvider.tracks duration seeking
- problem in play
- I have an error when it comes to template parsing errors.
- Customize UI of the provided html tags
- How can I post all of the tracks playing at the same time?
- Want to stop any audio properly
- Not able to Play M3u Files . HOT 1
- on iOS lock screen, I can't play the audio
- Ionic 4 version? HOT 10
- Are there any way to have two audioProvider?
- I can't change the progress if the file is saved under assets/
- it doesn't work with local audio files, HOT 1
- preload metadata is not preloading tracks with local files - It works only on streaming HOT 1
- online audio file not working on device
- onFinish called while playing
- Cannot properly handle ExpressionChangedAfterItHasBeenCheckedError
- AudioProvider replace function
- Change volume
- ERROR in Error during template compile of 'IonicAudioModule'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ionic-audio.