migrate apply error when fk changed

[idc77]

migrate apply error when fk changed

[masseelch]

Hey! This migration fails because of a data dependent change. You are adding a foreign key on data where that does not satisfy this constraint.

In your case the image table seems to hold a row with an recipe id that does not exist.

There are ways to fix this, e.g. by removing conflicting rows before applying the change.

I suggest you have a look at the atlas migrat lint command.

[idc77]

Ok but this isn't fixed.
I know what's happening, but this can still happen again anytime a field is added to the foreign key edge.

Before there was just an edge that went from recipe to image O2M.

Now the image has a named field "recipe_id", so the table had its field changed from recipe_image to recipe_id.
But the migration tool is unable to create a proper migration.

This is a bug.

Atlas is supposed to be a tool that keeps watch and helps with migrations, tracks changes and creates the SQL so that you can apply all the migrations in sequence.
In this case it doesn't do the job, it fails to do the job, creates a non-working migration.

[giautm]

Hello @idc77, you can use the StorageKey option to keep the old column, so any migration engine (ent’s or atlas) won’t try to drop and re-create the column for that field. Please let me know if it helps.

https://entgo.io/docs/schema-fields/#storage-key

[masseelch]

I just see now that it drops and re-creates the column, sorry missed that before. It's not really possible to determine if for a change made in the desired schema if it's a rename (like in your case) or a drop+add with equal types.

This is one of the reasons why there is atlas migrate lint. It would have told you that dropping a column is dangerous and most likely not intentional. Also, you can edit a generated migration and change the drop+add to a column rename. Or just use the StorageKey option as @giautm mentioned to keep the database column name.

However, we are actively working on solutions for these type of problems.