Giter Site home page Giter Site logo

Default value migration about atlas HOT 5 CLOSED

ariga avatar ariga commented on September 24, 2024
Default value migration

from atlas.

Comments (5)

fishead avatar fishead commented on September 24, 2024 1

@a8m patch is here #626, just let me known if it's not appropriate.
You are so friendly in the ent community.

from atlas.

a8m avatar a8m commented on September 24, 2024

Hey @fishead 👋

It should be fixed. Let me know if you want to contribute and I can guide you, or I can do it later today 🙏

from atlas.

fishead avatar fishead commented on September 24, 2024

I'm glad to make a PR.

from atlas.

a8m avatar a8m commented on September 24, 2024

Here's where we handle the default values:
https://github.com/ariga/atlas/blob/master/sql/mysql/inspect.go#L240
https://github.com/ariga/atlas/blob/master/sql/postgres/inspect.go#L181
https://github.com/ariga/atlas/blob/master/sql/sqlite/inspect.go#L141

We should use defaults.Valid instead of sqlx.ValidString. Just note that I added a commit (sqltest) in #622 to fix testing for it, so rebase and it's merged.

from atlas.

a8m avatar a8m commented on September 24, 2024

Fixed with #626. Thanks a lot @fishead

from atlas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.