Build error after #796 changes NVML_DEVICE_NAME_BUFFER_SIZE to RSMI_DEVICE_NAME_BUFFER_SIZE

[sbradnick]

Build error after #796 changes NVML_DEVICE_NAME_BUFFER_SIZE to RSMI_DEVICE_NAME_BUFFER_SIZE

[aristocratos]

@sbradnick
Do you wanna try moving line 163 in btop_collect.cpp:

#define RSMI_DEVICE_NAME_BUFFER_SIZE 128

up two lines so it looks like this:

namespace Rsmi {
    #define RSMI_DEVICE_NAME_BUFFER_SIZE 128
	#if !defined(RSMI_STATIC)
		//? RSMI defines, structs & typedefs
		#define RSMI_MAX_NUM_FREQUENCIES_V5  32

and then try compiling again.

[sbradnick]

@sbradnick Do you wanna try moving line 163 in btop_collect.cpp:

#define RSMI_DEVICE_NAME_BUFFER_SIZE 128

up two lines so it looks like this:

namespace Rsmi {
    #define RSMI_DEVICE_NAME_BUFFER_SIZE 128
	#if !defined(RSMI_STATIC)
		//? RSMI defines, structs & typedefs
		#define RSMI_MAX_NUM_FREQUENCIES_V5  32

and then try compiling again.

That makes the build successful. Only other oddity is how different the spacing is (tabs vs. spaces) for that line vs. the others and what the expected indentation should be (if it matters), when comparing to your "so it looks like this" example. Thanks for getting back to me! 😄

[aristocratos]

@sbradnick

That makes the build successful.

Great :)

Only other oddity is how different the spacing is (tabs vs. spaces) for that line vs. the others and what the expected indentation should be

That's probably just github messing up the formatting when I moved it around in the code snippet.

Anyways, fixed in latest commits.