Giter Site home page Giter Site logo

Comments (8)

arkaitzgarro avatar arkaitzgarro commented on July 20, 2024 1

It occurred to me that the 1.x branch we are proposing to support Laravel ^5.5 <6.0 will introduce breaking changes in what should be a minor release (following semver). What do you think about release that as 2.x and moving these release to 3.x? The 2.x line will start the new Agent and provide pre-Laravel 6 support (to a reasonable extent) while the 3.x line will move the project features forward and provide Laravel 6+ support. That will prevent surprises for your current users and make it easier to communicate what release to use.

I agree. I will release 3.0 for now, and wait until we make sure 2.x branch work as expected on L5.5 applications.

from elastic-apm-laravel.

dstepe avatar dstepe commented on July 20, 2024

I think the removal of Guzzle is a BC for most people. It fixes a specific use case, but I don't see that it was previously reported, so the release notes should probably point out what most people will experience, a need to add a new dependency as part of the upgrade.

The only other thing that comes to mind relates to the jobCollector. If that was present in the previous release, would it not have exhibited the send failures reported in #57 and fixed in #77? It that was not in the previous release, then it should be added as a new feature.

from elastic-apm-laravel.

dstepe avatar dstepe commented on July 20, 2024

It occurred to me that the 1.x branch we are proposing to support Laravel ^5.5 <6.0 will introduce breaking changes in what should be a minor release (following semver). What do you think about release that as 2.x and moving these release to 3.x? The 2.x line will start the new Agent and provide pre-Laravel 6 support (to a reasonable extent) while the 3.x line will move the project features forward and provide Laravel 6+ support. That will prevent surprises for your current users and make it easier to communicate what release to use.

from elastic-apm-laravel.

arkaitzgarro avatar arkaitzgarro commented on July 20, 2024

I think the removal of Guzzle is a BC for most people. It fixes a specific use case, but I don't see that it was previously reported, so the release notes should probably point out what most people will experience, a need to add a new dependency as part of the upgrade.

Yes, this is a good point, I will make it part of the release note. Thanks.

The only other thing that comes to mind relates to the jobCollector. If that was present in the previous release, would it not have exhibited the send failures reported in #57 and fixed in #77? It that was not in the previous release, then it should be added as a new feature.

Correct, this is something that we also fixed 👍

from elastic-apm-laravel.

dstepe avatar dstepe commented on July 20, 2024

I'm working on what is now the 1.x branch. I may not be able to complete it today unfortunately, but hopefully tomorrow.

from elastic-apm-laravel.

arkaitzgarro avatar arkaitzgarro commented on July 20, 2024

I'm working on what is now the 1.x branch. I may not be able to complete it today unfortunately, but hopefully tomorrow.

You mean 2.x branch right? I will create a 3.0 release for L6 support and 2.0 for L5.5. Latest changes are be available on 2.x branch already.

from elastic-apm-laravel.

dstepe avatar dstepe commented on July 20, 2024

Well, yes. It was still named 1.x when I started. I'll get caught up. :)

from elastic-apm-laravel.

arkaitzgarro avatar arkaitzgarro commented on July 20, 2024

v3.0 has been released 🎉

from elastic-apm-laravel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.