Queueig requests to elasticsearch (sending in background)

[arkaitzgarro]

Queueig requests to elasticsearch (sending in background)

[dstepe]

This is really a concern for the APM Agent package which is used to send the events. I did look into making the send to APM an async call, but that's not a straightforward as I had thought it would be. See this old PR and the link to discussion on the Guzzle project about the need to implement an event loop for that to work.

My hope is that the official APM PHP Agent will bring some major improvements.

In the meantime, this package defers sending the collected event data to APM until after the response has been sent to the client. This at least prevents connection issues from impacting the application's response. Running from the CLI is different, of course.

You can mange the http client used by the agent, though, which would give you the ability to set a shorter timeout. For example, in your AppServiceProvider::register() method:

$this->app->bind(\AG\ElasticApmLaravelAgentBuilder::class, function () {
    $builder = new \AG\ElasticApmLaravelAgentBuilder();

    $builder->withHttpClient(new \Http\Adapter\Guzzle6\Client(new Client(['timeout' => 3.0])));

    return $builder;
});

[arkaitzgarro]

Even if we send requests after the response is sent to the client, indeed the request to APM is sync and blocking. We had an issue today were APM server was not responding properly, making our application unstable. @rogercbe did you try the solution proposed by @dstepe to override the http client?

[countless-integers]

\AG\ElasticApmLaravelAgentBuilder

You meant \AG\ElasticApmLaravel\AgentBuilder, right @dstepe?

Ok, for completeness we came up with this:

$this->app->bind(\AG\ElasticApmLaravel\AgentBuilder::class, function () {
    return (new \AG\ElasticApmLaravel\AgentBuilder())
        ->withHttpClient(\Http\Adapter\Guzzle6\Client::createWithConfig(['timeout' => 3.0]));
});

[dstepe]

@countless-integers Yes, I'm sure that's what I meant. I can't explain where that \ went. Apologies.

[arkaitzgarro]

@rogercbe please try the solution above, it worked for us. I'm closing the issue since it is not related to this package and we have a workaround for it.