Max trace items is applied per collector rather than to total events

[arkaitzgarro]

Max trace items is applied per collector rather than to total events

[arkaitzgarro]

I think we should fix the implementation indeed. I like the idea of having a global counter to avoid collecting events that we will discard later on, and since all measurements are centralised in EventDataCollector class, we can easily discard events once the user reaches the limit.

What do you think about also implementing this limit in the PHP Agent? Is not as performant as not collecting events, but will solve this problem for every implementation.

[dstepe]

I agree with fixing the implementation as described. I assume this is not a high priority, though, or someone would have raised the issue by now. So maybe this waits for the next minor release while we finish the current work.

I do plan to make significant changes to the event tracking in the agent package as a next major release. This problem would be one that could be addressed.

[cykirsch]

This is great. We do hit the limit frequently on one of our APIs. I hadn't dug into how to fix but did notice that everything is collected and not limited until later, so there's a memory benefit for sure.